From: Jiri Pirko <jiri@resnulli.us>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alex Balcanquall <alex@alexbal.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation
Date: Wed, 13 Sep 2023 09:51:22 +0200 [thread overview]
Message-ID: <ZQFp+vdoedzshCpZ@nanopsycho> (raw)
In-Reply-To: <20230913052647.407420-1-mika.westerberg@linux.intel.com>
Wed, Sep 13, 2023 at 07:26:47AM CEST, mika.westerberg@linux.intel.com wrote:
>Alex reported that running ssh over IPv6 does not work with
>Thunderbolt/USB4 networking driver. The reason for that is that driver
>should call skb_is_gso() before calling skb_is_gso_v6(), and it should
>not return false after calculates the checksum successfully. This probably
>was a copy paste error from the original driver where it was done properly.
>
>Reported-by: Alex Balcanquall <alex@alexbal.com>
>Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable")
>Cc: stable@vger.kernel.org
Interesting, it is not actually cced. No need to do it anyway.
>Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-09-13 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 5:26 [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation Mika Westerberg
2023-09-13 5:55 ` Eric Dumazet
2023-09-13 7:51 ` Jiri Pirko [this message]
2023-09-14 1:20 ` Alex Balcanquall
2023-09-15 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQFp+vdoedzshCpZ@nanopsycho \
--to=jiri@resnulli.us \
--cc=YehezkelShB@gmail.com \
--cc=alex@alexbal.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox