Re: [RFC bpf-next 12/23] xdp: Add checksum hint

Alexander Lobakin
2023-09-14T16:35:38Z

From: Larysa Zaremba <larysa.zaremba@intel.com>
Date: Thu, 24 Aug 2023 21:26:51 +0200

> Implement functionality that enables drivers to expose to XDP code checksum
> information that consists of:
>
> - Checksum status - 2 non-exlusive flags:
> - XDP_CHECKSUM_VERIFIED indicating HW has validated the checksum
> (corresponding to CHECKSUM_UNNECESSARY in sk_buff)
> - XDP_CHECKSUM_COMPLETE signifies the validity of the second argument
> (corresponding to CHECKSUM_COMPLETE in sk_buff)
> - Checksum, calculated over the entire packet, valid if the second flag is
> set
>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Only one stupid thing from me: when a line starts from '-' in the commit
message, some editors/viewers paint it red thinking it's a diff already
:z (same for '+')
Not something important, you just may want to prefer "neutral" '*', up
to you :D

> ---
> Documentation/networking/xdp-rx-metadata.rst | 3 +++
> include/net/xdp.h | 15 +++++++++++++
> kernel/bpf/offload.c | 2 ++
> net/core/xdp.c | 23 ++++++++++++++++++++
> 4 files changed, 43 insertions(+)

[...]

Thanks,
Olek