Re: [RFC bpf-next 10/23] ice: Implement VLAN tag hint

Larysa Zaremba
2023-09-04T18:26:39Z

On Mon, Sep 04, 2023 at 06:00:34PM +0200, Maciej Fijalkowski wrote:
> On Thu, Aug 24, 2023 at 09:26:49PM +0200, Larysa Zaremba wrote:
> > Implement .xmo_rx_vlan_tag callback to allow XDP code to read
> > packet's VLAN tag.
> >
> > At the same time, use vlan_tci instead of vlan_tag in touched code,
> > because vlan_tag is misleading.
>
> misleading...because? ;)
>

VLAN tag ofter refers to VLAN proto and VLAN TCI combined, while in the
corrected code we clearly store only VLAN TCI.

Will add the above to the commit message.

> >
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_main.c | 22 ++++++++++++++++
> > drivers/net/ethernet/intel/ice/ice_txrx.c | 6 ++---
> > drivers/net/ethernet/intel/ice/ice_txrx.h | 1 +
> > drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 26 +++++++++++++++++++
> > drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 4 +--
> > drivers/net/ethernet/intel/ice/ice_xsk.c | 6 ++---
> > 6 files changed, 57 insertions(+), 8 deletions(-)
> >