netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Ahern <dsahern@kernel.org>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ido Schimmel <idosch@idosch.org>,
	Thomas Haller <thaller@redhat.com>
Subject: Re: [PATCH net-next] ipv6: do not merge differe type and protocol routes
Date: Fri, 15 Sep 2023 10:23:43 +0800	[thread overview]
Message-ID: <ZQPAL84/w323CgNT@Laptop-X1> (raw)
In-Reply-To: <bf3bb290-25b7-e327-851a-d6a036daab03@6wind.com>

On Fri, Sep 01, 2023 at 11:36:51AM +0200, Nicolas Dichtel wrote:
> > I do agree now that protocol is informative (passthrough from the kernel
> > perspective) so not really part of the route. That should be dropped

I'm not sure. Is there any user space route daemon will use this info? e.g. some
BGP route daemon?

> > from the patch leaving just a check on rt_type as to whether the routes
> > are different. From there the append, prepend, replace and change
> > semantics should decide what happens (ie., how the route is inserted).
> Right. What can guide us is the meaning/concept/benefit of having this kind of
> routing table:
> local 2001:db8:103::/64 via 2001:db8:101::10 dev dummy1 metric 1024 pref medium
> 2001:db8:103::/64 via 2001:db8:101::10 dev dummy2 metric 1024 pref medium
> 
> I don't understand how this is used/useful. It's why I ask for the use case/goal
> of this patch.
> How does the user know which route is used?

I'm not sure how user will use it. Maybe just block/forward some traffic to
local first and remove the local route later to unblock them. IPv4 can also
do like this. e.g.

+ ip link add dummy1 up type dummy
+ ip link add dummy2 up type dummy
+ ip addr add 192.168.0.1/24 dev dummy1
+ ip addr add 192.168.0.2/24 dev dummy2
+ ip route add local 192.168.3.0/24 dev dummy1 table 100
+ ip route append unicast 192.168.3.0/24 dev dummy1 table 100
+ ip route append unicast 192.168.3.0/24 dev dummy2 table 100
+ ip route show table 100
local 192.168.3.0/24 dev dummy1 scope host
192.168.3.0/24 dev dummy1 scope link
192.168.3.0/24 dev dummy2 scope link

Thanks
Hangbin

  reply	other threads:[~2023-09-15  2:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  6:15 [PATCH net-next] ipv6: do not merge differe type and protocol routes Hangbin Liu
2023-08-30 14:49 ` David Ahern
2023-08-30 23:51   ` Hangbin Liu
2023-08-30 15:29 ` Nicolas Dichtel
2023-08-30 18:57   ` David Ahern
2023-08-31  8:17     ` Nicolas Dichtel
2023-08-31 10:14       ` Hangbin Liu
2023-08-31 11:58         ` Nicolas Dichtel
2023-08-31 18:27           ` David Ahern
2023-09-01  9:36             ` Nicolas Dichtel
2023-09-15  2:23               ` Hangbin Liu [this message]
2023-09-15  3:08                 ` David Ahern
2023-09-15 10:02                   ` Hangbin Liu
2023-09-01  3:58           ` Hangbin Liu
2023-09-01  9:50             ` Nicolas Dichtel
2023-09-15  3:49               ` Hangbin Liu
2023-09-15 15:58                 ` Nicolas Dichtel
  -- strict thread matches above, loose matches on Subject: below --
2023-08-30  6:16 Hangbin Liu
2023-08-30  9:37 ` Hangbin Liu
2023-08-30  9:48   ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQPAL84/w323CgNT@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=idosch@idosch.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=thaller@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).