From: Daniel Golle <daniel@makrotopia.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com,
nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-mediatek@lists.infradead.org, sujuan.chen@mediatek.com,
horms@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 net-next 09/17] net: ethernet: mtk_wed: fix EXT_INT_STATUS_RX_FBUF definitions for MT7986 SoC
Date: Mon, 18 Sep 2023 12:35:31 +0100 [thread overview]
Message-ID: <ZQg2AxAIxkadOiIr@makrotopia.org> (raw)
In-Reply-To: <ebde071cc3cc9c35b00366c41912ee2f25e5282d.1695032291.git.lorenzo@kernel.org>
On Mon, Sep 18, 2023 at 12:29:11PM +0200, Lorenzo Bianconi wrote:
> Fix MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH and
> MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH definitions for MT7986 (MT7986 is
> the only SoC to use them).
Afaik this applies also to MT7981 which is very similar to MT7986.
>
> Fixes: de84a090d99a ("net: ethernet: mtk_eth_wed: add wed support for mt7986 chipset")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/ethernet/mediatek/mtk_wed_regs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_wed_regs.h b/drivers/net/ethernet/mediatek/mtk_wed_regs.h
> index 47ea69feb3b2..f87ab9b8a590 100644
> --- a/drivers/net/ethernet/mediatek/mtk_wed_regs.h
> +++ b/drivers/net/ethernet/mediatek/mtk_wed_regs.h
> @@ -64,8 +64,8 @@ struct mtk_wdma_desc {
> #define MTK_WED_EXT_INT_STATUS_TKID_TITO_INVALID BIT(4)
> #define MTK_WED_EXT_INT_STATUS_TX_FBUF_LO_TH BIT(8)
> #define MTK_WED_EXT_INT_STATUS_TX_FBUF_HI_TH BIT(9)
> -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(12)
> -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(13)
> +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(10) /* wed v2 */
> +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(11) /* wed v2 */
> #define MTK_WED_EXT_INT_STATUS_RX_DRV_R_RESP_ERR BIT(16)
> #define MTK_WED_EXT_INT_STATUS_RX_DRV_W_RESP_ERR BIT(17)
> #define MTK_WED_EXT_INT_STATUS_RX_DRV_COHERENT BIT(18)
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-09-18 11:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 10:29 [PATCH v2 net-next 00/17] Add WED support for MT7988 chipset Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 01/17] dt-bindings: soc: mediatek: mt7986-wo-ccif: add binding for MT7988 SoC Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 02/17] dt-bindings: arm: mediatek: mt7622-wed: add WED " Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 03/17] net: ethernet: mtk_wed: introduce versioning utility routines Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 04/17] net: ethernet: mtk_wed: do not configure rx offload if not supported Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 05/17] net: ethernet: mtk_wed: rename mtk_rxbm_desc in mtk_wed_bm_desc Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 06/17] net: ethernet: mtk_wed: introduce mtk_wed_buf structure Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 07/17] net: ethernet: mtk_wed: move mem_region array out of mtk_wed_mcu_load_firmware Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 08/17] net: ethernet: mtk_wed: make memory region optional Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 09/17] net: ethernet: mtk_wed: fix EXT_INT_STATUS_RX_FBUF definitions for MT7986 SoC Lorenzo Bianconi
2023-09-18 11:35 ` Daniel Golle [this message]
2023-09-18 12:17 ` Lorenzo Bianconi
2023-09-19 14:07 ` Paolo Abeni
2023-09-18 10:29 ` [PATCH v2 net-next 10/17] net: ethernet: mtk_wed: add mtk_wed_soc_data structure Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 11/17] net: ethernet: mtk_wed: introduce WED support for MT7988 Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 12/17] net: ethernet: mtk_wed: refactor mtk_wed_check_wfdma_rx_fill routine Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 13/17] net: ethernet: mtk_wed: introduce partial AMSDU offload support for MT7988 Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 14/17] net: ethernet: mtk_wed: introduce hw_rro " Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 15/17] net: ethernet: mtk_wed: debugfs: move wed_v2 specific regs out of regs array Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 16/17] net: ethernet: mtk_wed: debugfs: add WED 3.0 debugfs entries Lorenzo Bianconi
2023-09-18 10:29 ` [PATCH v2 net-next 17/17] net: ethernet: mtk_wed: add wed 3.0 reset support Lorenzo Bianconi
2023-09-19 17:20 ` [PATCH v2 net-next 00/17] Add WED support for MT7988 chipset patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQg2AxAIxkadOiIr@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).