From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF111D686 for ; Mon, 18 Sep 2023 16:07:15 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F3A59E2 for ; Mon, 18 Sep 2023 09:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yTRpoHAtEnJNybM7+Zhr0WgpKJefB3Ur0aO/o5Mjaug=; b=PBftq/IcLGdUFGTvxHSDKia04v j/wdD0YEYkI7SWvTXgmLLN3ZibfIb3Uyv6Z1V01ZZaHQ/Cp9+MLygqiXphmYpFaNasBeuOG3fmos/ vQz7n7/vQV2WLwakojQEPi/IfL+nd1NvC6QOjmtXmUpoWoGBiQbtk7ioD0zxrRrU0axgHoFwgxc5n VTud5cHtkkWECSEBgb69gwmJsXlC7gEE9H1jmCWP6h5o5aj4bT8Al29zTr7ED5BTZtuSzVheTnohj U+4TvFhnezGeRJdJKEUoJyaktwgzFqy8RU3Jom6YNYmE6YORq65PCzISydSd2pSNei9dIRhtaxlyZ hS61A1ig==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45154) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qiDxs-0000HU-2L; Mon, 18 Sep 2023 14:07:00 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qiDxt-0000Uk-JX; Mon, 18 Sep 2023 14:07:01 +0100 Date: Mon, 18 Sep 2023 14:07:01 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Marek Szyprowski , Heiner Kallweit , chenhao418@huawei.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jijie Shao , lanhao@huawei.com, liuyonglong@huawei.com, netdev@vger.kernel.org, Paolo Abeni , shenjian15@huawei.com, wangjie125@huawei.com, wangpeiyang1@huawei.com Subject: Re: [PATCH net-next 1/7] net: phy: always call phy_process_state_change() under lock Message-ID: References: <42ef8c8f-2fc0-a210-969b-7b0d648d8226@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Sep 18, 2023 at 02:55:32PM +0200, Andrew Lunn wrote: > > This probably need to be fixed somewhere in drivers/net/usb/asix* but at > > the first glance I don't see any obvious place that need a fix. > > static int __asix_mdio_read(struct net_device *netdev, int phy_id, int loc, > bool in_pm) > { > struct usbnet *dev = netdev_priv(netdev); > __le16 res; > int ret; > > mutex_lock(&dev->phy_mutex); > > Taking this lock here is the problem. Same for write. > > There is some funky stuff going on in asix_devices.c. It using both > phylib and the much older mii code. I don't think that's the problem... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!