From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C588830F96 for ; Tue, 19 Sep 2023 08:14:50 +0000 (UTC) Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EDF5FB for ; Tue, 19 Sep 2023 01:14:49 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qiVsO-0004jH-01; Tue, 19 Sep 2023 08:14:32 +0000 Date: Tue, 19 Sep 2023 09:14:23 +0100 From: Daniel Golle To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 5/9] net: dsa: mt7530: Convert to platform remove callback returning void Message-ID: References: <20230918191916.1299418-1-u.kleine-koenig@pengutronix.de> <20230918191916.1299418-6-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230918191916.1299418-6-u.kleine-koenig@pengutronix.de> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Sep 18, 2023 at 09:19:12PM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Acked-by: Daniel Golle > --- > drivers/net/dsa/mt7530-mmio.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dsa/mt7530-mmio.c b/drivers/net/dsa/mt7530-mmio.c > index 0a6a2fe34e64..b74a230a3f13 100644 > --- a/drivers/net/dsa/mt7530-mmio.c > +++ b/drivers/net/dsa/mt7530-mmio.c > @@ -63,15 +63,12 @@ mt7988_probe(struct platform_device *pdev) > return dsa_register_switch(priv->ds); > } > > -static int > -mt7988_remove(struct platform_device *pdev) > +static void mt7988_remove(struct platform_device *pdev) > { > struct mt7530_priv *priv = platform_get_drvdata(pdev); > > if (priv) > mt7530_remove_common(priv); > - > - return 0; > } > > static void mt7988_shutdown(struct platform_device *pdev) > @@ -88,7 +85,7 @@ static void mt7988_shutdown(struct platform_device *pdev) > > static struct platform_driver mt7988_platform_driver = { > .probe = mt7988_probe, > - .remove = mt7988_remove, > + .remove_new = mt7988_remove, > .shutdown = mt7988_shutdown, > .driver = { > .name = "mt7530-mmio", > -- > 2.40.1 > >