From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FD23B7AD for ; Tue, 19 Sep 2023 15:21:07 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03909BC for ; Tue, 19 Sep 2023 08:21:04 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2D2B65C0127; Tue, 19 Sep 2023 11:21:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Sep 2023 11:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695136864; x=1695223264; bh=RYZQV/afaZN6d 3w6KRS3aGSW8L5oIQdtZ+qcJ9O+p0g=; b=WnJEbIxIy+wq0VBsYtE6a5GI5zDoP qJUTo2LPSLypoAmEg6bq11fu1HtzIlHs5wRVpJYtlPRPbbMFFb3Vdlf0sxA2AbPZ v5zhG/v56JKpLlEiShNcdJ90NRnS3svMW7isAi3ZfmkK67Mmoo+phrZgt2G5JVc2 fuWJ3Iscs7VQQ2fo0akrHkp7ztpuK5hn6TT4fwSgz6cDdFYkvnr1mWHAA0cny9QA 2ENg5ofZeE2OJOt4Rx/w8QY1xoNa7FEWVha358CYc9Rz6x7Cplj/Oc6xg55THtpl OcRIM2YIustJgRrWIyz/oCx2pQ6NfK3FllolUyLYRcPDCCavxBnYTRwLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekuddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Sep 2023 11:21:02 -0400 (EDT) Date: Tue, 19 Sep 2023 18:20:59 +0300 From: Ido Schimmel To: Benjamin Poirier Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Nikolay Aleksandrov , Simon Horman , Jiri Benc , Gavin Li , Hangbin Liu , Vladimir Nikishkin , Li Zetao , Thomas Graf , Tom Herbert , Roopa Prabhu Subject: Re: [PATCH net] vxlan: Add missing entries to vxlan_get_size() Message-ID: References: <20230918154015.80722-1-bpoirier@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230918154015.80722-1-bpoirier@nvidia.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Sep 18, 2023 at 11:40:15AM -0400, Benjamin Poirier wrote: > There are some attributes added by vxlan_fill_info() which are not > accounted for in vxlan_get_size(). Add them. > > I didn't find a way to trigger an actual problem from this miscalculation > since there is usually extra space in netlink size calculations like > if_nlmsg_size(); but maybe I just didn't search long enough. > > Fixes: 3511494ce2f3 ("vxlan: Group Policy extension") > Fixes: e1e5314de08b ("vxlan: implement GPE") > Fixes: 0ace2ca89cbd ("vxlan: Use checksum partial with remote checksum offload") > Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device") > Signed-off-by: Benjamin Poirier Reviewed-by: Ido Schimmel