From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E971199DD for ; Thu, 21 Sep 2023 17:05:56 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977F9A5C2 for ; Thu, 21 Sep 2023 10:05:54 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E7EEE32009ED; Thu, 21 Sep 2023 08:09:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 21 Sep 2023 08:09:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695298168; x=1695384568; bh=j9l1iUgC0pIY3 8j8kkS173GVTz7E0Zg5FtYlimNdc1Q=; b=BXAL3cftBayzpsqFv5k/MafAFDkzx kVCen8ISvlHaatt0bZVZ2+L4HGXWrIS8j4t6BjYaPHDYC3YMecCkVp7eo6KI/nAZ mGHdVBvyEw891k9zrRe1P4c1lhQZTmbokmYunY07TVO12NT4KoOt+Usd15znsdXP PMA+bDPT+VbSZi7eOzDUQf46Yx+dS6s96AInMBL39VoJewulTJrv0yu2aEBJRLpF Cpi0k3x83kU/zLqM82mr1QgUMsQsc7iFsTJxxSGlK5IBhQPl92Bq5F5ql7NaKCvl c5eBH81J0GAkNvGEFcNICuzoxniqcP1bJye8dsMbneKnttYsPdr1C5pSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekiedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Sep 2023 08:09:26 -0400 (EDT) Date: Thu, 21 Sep 2023 15:09:22 +0300 From: Ido Schimmel To: "Drewek, Wojciech" Cc: Jakub Kicinski , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Kitszel, Przemyslaw" , "idosch@nvidia.com" Subject: Re: [PATCH iwl-next v2] ice: Disable Cage Max Power override Message-ID: References: <20230824085459.35998-1-wojciech.drewek@intel.com> <20230824083201.79f79513@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 15, 2023 at 01:15:01PM +0000, Drewek, Wojciech wrote: > In ice driver port split works per device not per port. According to > /Documentation/networking/devlink/ice.rst, section "Port split": > The "ice" driver supports port splitting only for port 0, as the FW has > a predefined set of available port split options for the whole device. > And if you look at available port options (same file) you'll see that in case of "Split count" 1 > only quad 1 is working. And in case of "Split count" 2 the second quad might be used. So, if we > increase max_pwr in the first quad in case of "Split count" 1 and then switch to "Split count" 2, > the second quad might end up with no link (because it will have decreased max_pwr). But there's also an option where the second cage isn't actually used. Anyway, my suggestion is to allow user space to set / get the max power using ethtool and give user space visibility about link down reason via the ethtool extended state.