From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8793B4CFAA; Thu, 21 Sep 2023 18:11:27 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F2B692398; Thu, 21 Sep 2023 10:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rAUrRXnUzYYs/ew/1+KqF9kOieRZwvt3pCV3uohg47o=; b=vWr3hI5zrx2FBuVlw2/LK0K2+J RpsmBaMqsSd3EBLE9EatFJIs6wU1AuyBFBpv7ZlhQMRpsiHfe9mfdme077m0HBvbhlkF5FvLBvsPP c7gjed8tcT51Qn6sahiTz19sfcwAM3pG1xCNVhx09514YVO/JH1j5Oaa1AjpHBIeuIuARn9EerZ7l E+AqCdBxT8P4SouR5gGlkLRM+efMa0XWs152eUSvVU3McDVVOTvCtX6a2y+8T9qg+TnSW0MN35jcP nPMsXRyYy4krU5S9F1ZlbBMVtUtQCsG8g0jgZAWjKkBoEpEE+Jzuyy8HZLyihMuagq7sJnmcmRfc9 BVMXFjyw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41288) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qjKPl-0004n3-2L; Thu, 21 Sep 2023 15:12:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qjKPj-0003bq-AL; Thu, 21 Sep 2023 15:12:19 +0100 Date: Thu, 21 Sep 2023 15:12:19 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Choong Yong Liang , Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Jose Abreu , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , Tan Tee Min , Michael Sit Wei Hong , Lai Peter Jun Ann Subject: Re: [PATCH net-next v2 0/5] TSN auto negotiation between 1G and 2.5G Message-ID: References: <20230804084527.2082302-1-yong.liang.choong@linux.intel.com> <5bd05ba2-fd88-4e5c-baed-9971ff917484@lunn.ch> <37fe9352-ec84-47b8-bb49-9441987ca1b9@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37fe9352-ec84-47b8-bb49-9441987ca1b9@lunn.ch> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Sep 21, 2023 at 03:21:00PM +0200, Andrew Lunn wrote: > > Hi Andrew, > > > > After conducting a comprehensive study, it seems that implementing > > out-of-band for all link modes might not be feasible. I may have missed some > > key aspects during my analysis. > > > > Would you be open to sharing a high-level idea of how we could potentially > > make this feasible? Your insights would be greatly appreciated. > > stmmac_mac_link_up() gets passed interface, speed and duplex. That > tells you what the PHY has negotiated. Is there anything else you need > to know? The problem is... the stmmac driver is utter bollocks - that information is *not* passed to the BSP. Instead, stmmac parse and store information such as the PHY interface mode at initialisation time. BSPs also re- parse and store e.g. the PHY interface mode at initialisation time. The driver ignores what it gets from phylink. The driver is basically utter crap. That's an area I _had_ patches to clean up. I no longer do. stmmac is crap crap crap and will stay crap until they become more receptive to patches to fix it, even if the patches are not 100% to their liking but are in fact correct. Maybe if I ever decide to touch that driver in the future. Which I doubt given my recent experience. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!