From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>,
"Kamil Maziarz" <kamil.maziarz@intel.com>,
<magnus.karlsson@intel.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
Chandan Kumar Rout <chandanx.rout@intel.com>
Subject: Re: [PATCH net] ice: don't stop netdev tx queues when setting up XSK socket
Date: Wed, 4 Oct 2023 15:26:47 +0200 [thread overview]
Message-ID: <ZR1oF7he5WaToeR1@boxer> (raw)
In-Reply-To: <20231003154920.6ae3801f@kernel.org>
On Tue, Oct 03, 2023 at 03:49:20PM -0700, Jakub Kicinski wrote:
> On Mon, 25 Sep 2023 10:19:57 -0700 Tony Nguyen wrote:
> > Avoid stopping netdev tx queues during XSK setup by removing
> > netif_tx_stop_queue() and netif_tx_start_queue().
> > These changes prevent unnecessary stopping and starting of netdev
> > transmit queues during the setup of XDP socket. Without this change,
> > after stopping the XDP traffic flow tracker and then stopping
> > the XDP prog - NETDEV WATCHDOG transmit queue timed out appears.
what is xdp traffic flow tracker? what do you mean by stopping xdp prog -
or you removing it while keeping xsk pool present on interface? or are you
just downing interface?
can you provide steps to reproduce it?
>
> I think we need more info about what happens here.
>
> Maybe ice_qp_ena() fails before it gets to the start?
> If we don't understand what happens, exactly, we may be papering
> over other bugs.
+1
> --
> pw-bot: cr
>
prev parent reply other threads:[~2023-10-04 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 17:19 [PATCH net] ice: don't stop netdev tx queues when setting up XSK socket Tony Nguyen
2023-09-25 22:58 ` Jacob Keller
2023-10-03 22:49 ` Jakub Kicinski
2023-10-04 13:26 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR1oF7he5WaToeR1@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chandanx.rout@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kamil.maziarz@intel.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).