From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20F721A16 for ; Wed, 4 Oct 2023 20:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=infradead.org header.i=@infradead.org header.b="kbYSa7TK" Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3182DAD; Wed, 4 Oct 2023 13:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3UgUbzqswLEhIYLsMeLmJBtIHWsl9lF0pUcedalU9Rw=; b=kbYSa7TKEcTi7K3IrRBh2nEBXy Tob4nvzqSaB8CpDYrQe17wCHZI+LbZCqUp/bCxtyMYJdDa6QbhHFIxPZ29YlkiAtqcRVCnnIR6BG6 JZA9tt/5h1YjOHAbHo9j5maK4iYXeSzaMqt0Za2XVUi2aU2rZ1WzrAv1M8+GBqwxfgLjtjjHXxz6P Wr32lVeyU6m8UrSsRDBmziqA0LgfZYR/nMO46tj8FjLMzLAM18Zrf52zLpp1EihV4VMi1ndRxihid 2i9pEzQHIE2onxiMM834Ndmg5LY3KguTyNhxrJM3baUUdciH/LJIXE/RzempEn0niQHCOIv77NztR 8el9VzFg==; Received: from jlbec by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qo827-00Fp2x-0U; Wed, 04 Oct 2023 19:59:47 +0000 Date: Wed, 4 Oct 2023 12:59:38 -0700 From: Joel Becker To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, Eric Dumazet , hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org Subject: Re: [PATCH 1/3] netconsole: Initialize configfs_item for default targets Message-ID: Mail-Followup-To: Breno Leitao , kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, Eric Dumazet , hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org References: <20231002155349.2032826-1-leitao@debian.org> <20231002155349.2032826-2-leitao@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002155349.2032826-2-leitao@debian.org> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. Sender: Joel Becker X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Oct 02, 2023 at 08:53:47AM -0700, Breno Leitao wrote: > diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c > index 3111e1648592..b68456054a0c 100644 > --- a/drivers/net/netconsole.c > +++ b/drivers/net/netconsole.c > @@ -53,6 +53,8 @@ static bool oops_only = false; > module_param(oops_only, bool, 0600); > MODULE_PARM_DESC(oops_only, "Only log oops messages"); > > +#define DEFAULT_TARGET_NAME "cmdline" > + I'm not sure `DEFAULT` is the right terminology here. e.g. it's not a default for dynamic targets, etc. Perhaps `BOOT_TARGET_NAME` or `NETCONSOLE_PARAM_TARGET_NAME`? Joel -- "Friends may come and go, but enemies accumulate." - Thomas Jones http://www.jlbec.org/ jlbec@evilplan.org