From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584821A70C for ; Mon, 2 Oct 2023 14:53:31 +0000 (UTC) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6E99F for ; Mon, 2 Oct 2023 07:53:27 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5335725cf84so21195899a12.2 for ; Mon, 02 Oct 2023 07:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1696258406; x=1696863206; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Io8DiXqjSfTqepUgkoeQXJPEkLkiVe5602Ih+UtiRhc=; b=f/xLVPeBV+9eJvKYvh3WfL6mje4+7R8/p3/3FvEzCSDYjwHHn23aOgqS7x19LfyFit JE4IyT3At1UpFCfbAT8eZv6z5WSotF+BWLC40ZGKTFj3t9xl1CTCjXajRoP2pMyJ41tV iwy2MbC8AiwlhIjV1FARvA5R+/4vN1Vb5dbfgN4ickVpIvR/0tZ7SS+P2pxe7tFjARE5 Lua/pNojMpyH5zKqSBogqa+lSC2E9qmyjR6IJvYR4yjJhZKdV5xngyu+cbH4pBsxtvMw A1EIqMMab/H/8W8GPxmULVybQgD2aLQ+PYwNOGQaD5tIMcuSeMsMhHsbu6VjKgo3I2Nc 00eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696258406; x=1696863206; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Io8DiXqjSfTqepUgkoeQXJPEkLkiVe5602Ih+UtiRhc=; b=YFegJ2TV7JFHvyNH8YqoArb4f4iqvTued+h2DFcpNqkUX/XKzG1XjVQ5gcUZMbiqvo XIzN9pP+Iybsv/iaQW7tEiNoiWHnu2q9lNOn1p8QcE7o5muD6P/vuJbGK+cl2iBukxUP ifsplh3BstyYJE5JdGjs3AHcFa2Nmm0PlWawC4YcvJM0AAbZodySbHuG6lqMqXNc2umQ K6V1Kgr6iGluatle3FKy0IjjozOlcEOXV8QqZLhuuZMl43BCaCOefTwQmaQpcqkOGaY/ qVRZF5THLSZtc2ZDsXDcjfWqlmJIuKiFfR2gMY42C5GtO4N0L3Xu1FWttSFRskU9zri2 Nttw== X-Gm-Message-State: AOJu0YysWxvYdFIICEuK1yaz2jH3L+AqrAQcQ3PTQOpJxXiYagGV7qFq qjKYASbC6InFUD6O5gmaz9elbA== X-Google-Smtp-Source: AGHT+IGLdofiABYnVTHaKEqx4FAGXdzNwFEC1xhDWk5ks3eDjq8Ai96j3n5CHrYeigrr56gl72n0Wg== X-Received: by 2002:a05:6402:1481:b0:530:5465:ad6d with SMTP id e1-20020a056402148100b005305465ad6dmr9956304edv.2.1696258406261; Mon, 02 Oct 2023 07:53:26 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id cy23-20020a0564021c9700b005362c9905b2sm6638316edb.35.2023.10.02.07.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 07:53:25 -0700 (PDT) Date: Mon, 2 Oct 2023 16:53:24 +0200 From: Jiri Pirko To: Arkadiusz Kubalewski Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev, corbet@lwn.net, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust Message-ID: References: <20230927092435.1565336-1-arkadiusz.kubalewski@intel.com> <20230927092435.1565336-3-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927092435.1565336-3-arkadiusz.kubalewski@intel.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Wed, Sep 27, 2023 at 11:24:33AM CEST, arkadiusz.kubalewski@intel.com wrote: >Add new pin's attributes to dpll netlink spec: >- phase-offset - measured difference between phase of signals on pin > and dpll >- phase-adjust - adjustable value of pin's signal phase >- phase-adjust-min / phase-adjust-max - values for determining limits > for phase-adjust > >Signed-off-by: Arkadiusz Kubalewski >--- > Documentation/netlink/specs/dpll.yaml | 33 ++++++++++++++++++++++++++- > drivers/dpll/dpll_nl.c | 8 ++++--- > drivers/dpll/dpll_nl.h | 2 +- > include/uapi/linux/dpll.h | 8 ++++++- > 4 files changed, 45 insertions(+), 6 deletions(-) > >diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml >index 8b86b28b47a6..dc057494101f 100644 >--- a/Documentation/netlink/specs/dpll.yaml >+++ b/Documentation/netlink/specs/dpll.yaml >@@ -1,7 +1,7 @@ > # SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) > > name: dpll >- >+version: 2 How is this supposed to work. You bump the version with every uapi extension? First time I see this. [...] >diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h >index 20ef0718f8dc..050f51b48ef8 100644 >--- a/include/uapi/linux/dpll.h >+++ b/include/uapi/linux/dpll.h >@@ -7,7 +7,7 @@ > #define _UAPI_LINUX_DPLL_H > > #define DPLL_FAMILY_NAME "dpll" >-#define DPLL_FAMILY_VERSION 1 >+#define DPLL_FAMILY_VERSION 2