From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25130E56A; Tue, 3 Oct 2023 11:31:51 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549439E; Tue, 3 Oct 2023 04:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=734NRbey6LNjF6R5LmBVtB+1cSnVkKre8lbeKBodetI=; b=PDYW7AztC1pHCw3wGKmtfkTHpB qj19+US3uAB2HwkhlhO86L6h02RzPk0PWcq3io2UnD+bjI+0shQgSJzlZxRcYXZsJz+7LDqoRnIPl 7dCNP23mJCMiKLcAPolrhJ1wR+QcNpKGyncU/Z2s04bMIc+awnwq0CE7P9RnIALNASEH7Yty2cSlL EB558/UW88bbx/d8MIQTArGbwcT5EM1AKJf/wgFlEX+VhdGysJAdnksI/DRclkRWhcu3urr0AExgo MsHQ4Cc4RUaS+uyEJWzBYw63aMX6swqd5tLrnSE7Jg558ST27F4PyDUnwFhmpQkPIMhvGZgM8oWYI yfl3fh1g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57792) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qndcw-0001cu-03; Tue, 03 Oct 2023 12:31:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qndcx-0007qY-0s; Tue, 03 Oct 2023 12:31:47 +0100 Date: Tue, 3 Oct 2023 12:31:46 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Heiner Kallweit , Andrew Lunn , Florian Fainelli , Madalin Bucur , Ioana Ciornei , Camelia Groza , Li Yang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sean Anderson , Maxime Chevallier , Vinod Koul , Kishon Vijay Abraham I Subject: Re: [RFC PATCH v2 net-next 11/15] net: phylink: support the 25GBase-KR-S and 25GBase-CR-S link modes too Message-ID: References: <20230923134904.3627402-1-vladimir.oltean@nxp.com> <20230923134904.3627402-12-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230923134904.3627402-12-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Sat, Sep 23, 2023 at 04:49:00PM +0300, Vladimir Oltean wrote: > Treat the newly introduced subsets of 25GBase-KR and 25GBase-CR the same > way as the fully-featured link modes. The difference only consists in > RS-FEC support. As mentioned in the patch adding these new linkmodes, I wonder whether this should be part of that patch. Is there a reason to keep it separate? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!