From: Simon Horman <horms@kernel.org>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org, linux-sctp@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH nf] netfilter: handle the connecting collision properly in nf_conntrack_proto_sctp
Date: Tue, 3 Oct 2023 14:51:35 +0200 [thread overview]
Message-ID: <ZRwOVyKQR8MBjpBh@kernel.org> (raw)
In-Reply-To: <6ee630f777cada3259b29e732e7ea9321a99197b.1696172868.git.lucien.xin@gmail.com>
On Sun, Oct 01, 2023 at 11:07:48AM -0400, Xin Long wrote:
...
> @@ -481,6 +486,24 @@ int nf_conntrack_sctp_packet(struct nf_conn *ct,
> old_state == SCTP_CONNTRACK_CLOSED &&
> nf_ct_is_confirmed(ct))
> ignore = true;
> + } else if (sch->type == SCTP_CID_INIT_ACK) {
> + struct sctp_inithdr _ih, *ih;
> + u32 vtag;
> +
> + ih = skb_header_pointer(skb, offset + sizeof(_sch), sizeof(*ih), &_ih);
> + if (ih == NULL)
> + goto out_unlock;
> +
> + vtag = ct->proto.sctp.vtag[!dir];
> + if (!ct->proto.sctp.init[!dir] && vtag && vtag != ih->init_tag)
> + goto out_unlock;
> + /* collision */
> + if (ct->proto.sctp.init[dir] && ct->proto.sctp.init[!dir] &&
> + vtag != ih->init_tag)
The type of vtag is u32. But the type of ct->proto.sctp.vtag[!dir] and init_tag
is __be32. This doesn't seem right (and makes Sparse unhappy).
> + goto out_unlock;
> +
> + pr_debug("Setting vtag %x for dir %d\n", ih->init_tag, !dir);
> + ct->proto.sctp.vtag[!dir] = ih->init_tag;
> }
>
> ct->proto.sctp.state = new_state;
> --
> 2.39.1
>
>
next prev parent reply other threads:[~2023-10-03 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 15:07 [PATCH nf] netfilter: handle the connecting collision properly in nf_conntrack_proto_sctp Xin Long
2023-10-02 14:59 ` Xin Long
2023-10-02 15:18 ` Florian Westphal
2023-10-02 15:39 ` Xin Long
2023-10-02 16:48 ` Florian Westphal
2023-10-03 12:44 ` Simon Horman
2023-10-03 12:51 ` Simon Horman [this message]
2023-10-03 14:17 ` Xin Long
2023-10-03 14:23 ` Florian Westphal
2023-10-03 14:37 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRwOVyKQR8MBjpBh@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).