* [PATCH v2] net: lan743x: also select PHYLIB
@ 2023-10-02 19:35 Randy Dunlap
2023-10-03 13:58 ` Simon Horman
2023-10-05 16:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-10-02 19:35 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Bryan Whitehead, UNGLinuxDriver,
Simon Horman, netdev, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid
a kconfig warning:
WARNING: unmet direct dependencies detected for FIXED_PHY
Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
Selected by [y]:
- LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]
Fixes: 73c4d1b307ae ("net: lan743x: select FIXED_PHY")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: lore.kernel.org/r/202309261802.JPbRHwti-lkp@intel.com
Cc: Bryan Whitehead <bryan.whitehead@microchip.com>
Cc: UNGLinuxDriver@microchip.com
Cc: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
v2: Also Cc: netdev and Microchip people;
drivers/net/ethernet/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -46,6 +46,7 @@ config LAN743X
tristate "LAN743x support"
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
+ select PHYLIB
select FIXED_PHY
select CRC16
select CRC32
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: lan743x: also select PHYLIB
2023-10-02 19:35 [PATCH v2] net: lan743x: also select PHYLIB Randy Dunlap
@ 2023-10-03 13:58 ` Simon Horman
2023-10-05 16:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-10-03 13:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Bryan Whitehead, UNGLinuxDriver,
netdev, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Mon, Oct 02, 2023 at 12:35:44PM -0700, Randy Dunlap wrote:
> Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid
> a kconfig warning:
>
> WARNING: unmet direct dependencies detected for FIXED_PHY
> Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
> Selected by [y]:
> - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]
>
> Fixes: 73c4d1b307ae ("net: lan743x: select FIXED_PHY")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: lore.kernel.org/r/202309261802.JPbRHwti-lkp@intel.com
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: lan743x: also select PHYLIB
2023-10-02 19:35 [PATCH v2] net: lan743x: also select PHYLIB Randy Dunlap
2023-10-03 13:58 ` Simon Horman
@ 2023-10-05 16:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-05 16:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, lkp, bryan.whitehead, UNGLinuxDriver, horms, netdev,
davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 2 Oct 2023 12:35:44 -0700 you wrote:
> Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid
> a kconfig warning:
>
> WARNING: unmet direct dependencies detected for FIXED_PHY
> Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
> Selected by [y]:
> - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]
>
> [...]
Here is the summary with links:
- [v2] net: lan743x: also select PHYLIB
https://git.kernel.org/netdev/net/c/566aeed6871a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-05 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 19:35 [PATCH v2] net: lan743x: also select PHYLIB Randy Dunlap
2023-10-03 13:58 ` Simon Horman
2023-10-05 16:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).