From: Simon Horman <horms@kernel.org>
To: Michael Pratt <mcpratt@protonmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rafal Milecki <zajec5@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH v1 0/2] mac_pton: support more MAC address formats
Date: Tue, 3 Oct 2023 16:17:04 +0200 [thread overview]
Message-ID: <ZRwiYOH8wsNqPmED@kernel.org> (raw)
In-Reply-To: <20231002233946.16703-1-mcpratt@protonmail.com>
On Mon, Oct 02, 2023 at 11:39:55PM +0000, Michael Pratt wrote:
> Currently, mac_pton() strictly requires the standard ASCII MAC address format
> with colons as the delimiter, however,
> some hardware vendors don't store the address like that.
>
> If there is no delimiter, one could use strtoul()
> but that would leave out important checks to make sure
> that each character in the string is hexadecimal.
>
> This series adds support for other delimiters
> and lack of any delimiter to the mac_pton() function.
>
> Tested with Openwrt on a MIPS system (ar9344).
Hi Michael,
I am wondering if you considered a different approach where,
via parameters and/or new helpers, callers can specify the
delimiter, or absence thereof.
prev parent reply other threads:[~2023-10-03 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 23:39 [PATCH v1 0/2] mac_pton: support more MAC address formats Michael Pratt
2023-10-02 23:40 ` [PATCH 1/2] mac_pton: support MAC addresses with other delimiters Michael Pratt
2023-10-03 16:58 ` Stephen Hemminger
2023-10-02 23:40 ` [PATCH 2/2] mac_pton: support MAC addresses without delimiters Michael Pratt
2023-10-03 14:17 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRwiYOH8wsNqPmED@kernel.org \
--to=horms@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcpratt@protonmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).