From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323E879C1 for ; Fri, 6 Oct 2023 13:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rfJsOhJF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9177C433C7; Fri, 6 Oct 2023 13:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696598690; bh=o3GGCVpXVd8CErOLPgr8dEp7DvAX/9TjHNxkbvAx2Ms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rfJsOhJFE7q48tKMmozjOtul3zFQQYKVGQOOnDkF8R9JxpHRQZkAsuaNWF99Y7LA7 53zP1cbXK8YasHZ+OF/wrBQHnLwhlpbZ902UGFSj7hHxmo3rxsTtXnmOLRC2qHPhPf nOtEKvHMaBZuQD2LQFY2k+6lsJw4RgomuaX9Cc0NQpRCjdoh5q3GrJ71v3wRx9g7Fn Sh8AdT20EXHezVdFMW7uLaG7dwxRG9vaz03w34iIinTd7vpVa2lwjzq10mbzGl0cFW a/F7Vk1NcoZhGjXYlHNgM1VdfOKhZCpbhejOVlxbj8Gmi0al7qknFGEsKrvg0IcG+W 18d3/DW05u1gw== Date: Fri, 6 Oct 2023 15:24:45 +0200 From: Simon Horman To: Dan Carpenter Cc: Greg Rose , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] ixgbe: fix crash with empty VF macvlan list Message-ID: References: <3cee09b8-4c49-4a39-b889-75c0798dfe1c@moroto.mountain> <569ba96b-2bc3-45ea-b397-36e7ef88ed8f@kadam.mountain> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <569ba96b-2bc3-45ea-b397-36e7ef88ed8f@kadam.mountain> On Fri, Oct 06, 2023 at 03:49:39PM +0300, Dan Carpenter wrote: > On Fri, Oct 06, 2023 at 01:16:27PM +0200, Simon Horman wrote: > > On Thu, Oct 05, 2023 at 04:57:02PM +0300, Dan Carpenter wrote: > > > The adapter->vf_mvs.l list needs to be initialized even if the list is > > > empty. Otherwise it will lead to crashes. > > > > > > Fixes: c6bda30a06d9 ("ixgbe: Reconfigure SR-IOV Init") > > > > Hi Dan, > > > > I see that the patch cited above added the line you are changing. > > But it also seems to me that patch was moving it from elsewhere. > > > > Perhaps I am mistaken, but I wonder if this is a better tag. > > > > Fixes: a1cbb15c1397 ("ixgbe: Add macvlan support for VF") > > > > Yeah. You're right. I'll resend. Thanks! > > > Signed-off-by: Dan Carpenter > > > --- > > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > > > index a703ba975205..9cfdfa8a4355 100644 > > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > > > @@ -28,6 +28,9 @@ static inline void ixgbe_alloc_vf_macvlans(struct ixgbe_adapter *adapter, > > > struct vf_macvlans *mv_list; > > > int num_vf_macvlans, i; > > > > > > + /* Initialize list of VF macvlans */ > > > + INIT_LIST_HEAD(&adapter->vf_mvs.l); > > > + > > > num_vf_macvlans = hw->mac.num_rar_entries - > > > (IXGBE_MAX_PF_MACVLANS + 1 + num_vfs); > > > if (!num_vf_macvlans) > > > @@ -36,8 +39,6 @@ static inline void ixgbe_alloc_vf_macvlans(struct ixgbe_adapter *adapter, > > > mv_list = kcalloc(num_vf_macvlans, sizeof(struct vf_macvlans), > > > GFP_KERNEL); > > > if (mv_list) { > > > > I'm not sure it it is worth it, but perhaps more conventional error > > handling could be used here: > > > > if (!mv_list) > > return; > > > > for (i = 0; i < num_vf_macvlans; i++) { > > ... > > I mean error handling is always cleaner than success handling but it's > probably not worth cleaning up in old code. I say it's not worth > cleaning up old code and yet I secretly reversed two if statements like > this yesterday. :P > https://lore.kernel.org/all/d9da4c97-0da9-499f-9a21-1f8e3f148dc1@moroto.mountain/ > It really is nicer, yes. But it just makes the patch too noisy. Yeah, I'm also worried about the noise in this case.