From: Wei Liu <wei.liu@kernel.org>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: linux-kernel@vger.kernel.org,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ben Hutchings <bhutchings@solarflare.com>,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org
Subject: Re: [PATCH] xen-netback: use default TX queue size for vifs
Date: Fri, 6 Oct 2023 21:44:20 +0000 [thread overview]
Message-ID: <ZSB/tKydP056arIy@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20231005140831.89117-1-roger.pau@citrix.com>
On Thu, Oct 05, 2023 at 04:08:31PM +0200, Roger Pau Monne wrote:
> Do not set netback interfaces (vifs) default TX queue size to the ring size.
> The TX queue size is not related to the ring size, and using the ring size (32)
> as the queue size can lead to packet drops. Note the TX side of the vif
> interface in the netback domain is the one receiving packets to be injected
> to the guest.
>
> Do not explicitly set the TX queue length to any value when creating the
> interface, and instead use the system default. Note that the queue length can
> also be adjusted at runtime.
>
> Fixes: f942dc2552b8 ('xen network backend driver')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
next prev parent reply other threads:[~2023-10-06 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 14:08 [PATCH] xen-netback: use default TX queue size for vifs Roger Pau Monne
2023-10-06 13:15 ` Ross Lagerwall
2023-10-06 21:44 ` Wei Liu [this message]
2023-10-08 13:01 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSB/tKydP056arIy@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=Ian.Campbell@citrix.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).