Re: [patch net-next] devlink: don't take instance lock for nested handle put

Jiri Pirko
2023-10-07T10:17:37Z

Sat, Oct 07, 2023 at 12:14:46AM CEST, kuba@kernel.org wrote:
>On Fri, 6 Oct 2023 19:07:34 +0200 Jiri Pirko wrote:
>> >The user creates a port on an instance A, which spawns instance B.
>> >Instance A links instance B to itself.
>> >Instance A cannot disappear before instance B disappears.
>>
>> It can. mlx5 port sf removal is very nice example of that. It just tells
>> the FW to remove the sf and returns. The actual SF removal is spawned
>> after that when processing FW events.
>
>Isn't the PF driver processing the "FW events"? A is PF here, and B
>is SF, are you saying that the PF devlink instance can be completely
>removed (not just unregistered, freed) before the SF instance is
>unregistered?

Kernel-wise, yes. The FW probably holds necessary resource until SF goes
away.