netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shung-Hsi Yu <shung-hsi.yu@suse.com>
To: netdev@vger.kernel.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
	"David Ahern" <dsahern@kernel.org>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH iproute2-next 0/2] Increase BPF verifier verbosity when in verbose mode
Date: Wed, 18 Oct 2023 21:59:11 +0800	[thread overview]
Message-ID: <ZS_kr7X5Jwo4x360@u94a> (raw)
In-Reply-To: <20231018062234.20492-1-shung-hsi.yu@suse.com>

On Wed, Oct 18, 2023 at 02:22:32PM +0800, Shung-Hsi Yu wrote:
> When debugging BPF verifier issue, it is useful get as much information
> out of the verifier as possible to help diagnostic, but right now that
> is not possible because load_bpf_object() does not set the
> kernel_log_level in bpf_open_opts, which is addressed in patch 1.
> 
> Patch 2 further allows increasing the log level in verbose mode, so even
> more information can be retrieved out of the verifier, and most
> importlantly, show verifier log even on successful BPF program load.

Got some typos in patch 2, and bpf_open_opts should be bpf_object_open_opts.
Will send v2 to correct these mistakes.

> Shung-Hsi Yu (2):
>   libbpf: set kernel_log_level when available
>   bpf: increase verifier verbosity when in verbose mode
> 
>  include/bpf_util.h |  4 ++--
>  ip/ipvrf.c         |  3 ++-
>  lib/bpf_legacy.c   | 10 ++++++----
>  lib/bpf_libbpf.c   |  6 ++++++
>  4 files changed, 16 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 575322b09c3c6bc1806f2faa31edcfb64df302bb
> -- 
> 2.42.0
> 

      parent reply	other threads:[~2023-10-18 13:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  6:22 [PATCH iproute2-next 0/2] Increase BPF verifier verbosity when in verbose mode Shung-Hsi Yu
2023-10-18  6:22 ` [PATCH iproute2-next 1/2] libbpf: set kernel_log_level when available Shung-Hsi Yu
2023-10-18  6:22 ` [PATCH iproute2-next 2/2] bpf: increase verifier verbosity when in verbose mode Shung-Hsi Yu
2023-10-18 14:35   ` David Ahern
2023-10-19  1:18     ` Shung-Hsi Yu
2023-10-19 19:44       ` David Ahern
2023-10-20 12:09         ` Shung-Hsi Yu
2023-10-18 13:59 ` Shung-Hsi Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS_kr7X5Jwo4x360@u94a \
    --to=shung-hsi.yu@suse.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).