From: Jiri Pirko <jiri@resnulli.us>
To: Jiri Wiesner <jwiesner@suse.de>
Cc: netdev@vger.kernel.org, Moshe Tal <moshet@nvidia.com>,
Jussi Maki <joamaki@gmail.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] bonding: Return pointer to data after pull on skb
Date: Wed, 11 Oct 2023 18:16:26 +0200 [thread overview]
Message-ID: <ZSbKWoCUbL8HR7Ar@nanopsycho> (raw)
In-Reply-To: <20231010163933.GA534@incl>
Tue, Oct 10, 2023 at 06:39:33PM CEST, jwiesner@suse.de wrote:
>Since 429e3d123d9a ("bonding: Fix extraction of ports from the packet
>headers"), header offsets used to compute a hash in bond_xmit_hash() are
>relative to skb->data and not skb->head. If the tail of the header buffer
>of an skb really needs to be advanced and the operation is successful, the
>pointer to the data must be returned (and not a pointer to the head of the
>buffer).
>
>Fixes: 429e3d123d9a ("bonding: Fix extraction of ports from the packet headers")
>Signed-off-by: Jiri Wiesner <jwiesner@suse.de>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-10-11 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 16:39 [PATCH net] bonding: Return pointer to data after pull on skb Jiri Wiesner
2023-10-10 18:45 ` Jay Vosburgh
2023-10-11 16:16 ` Jiri Pirko [this message]
2023-10-13 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSbKWoCUbL8HR7Ar@nanopsycho \
--to=jiri@resnulli.us \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=joamaki@gmail.com \
--cc=jwiesner@suse.de \
--cc=kuba@kernel.org \
--cc=moshet@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).