From: Bagas Sanjaya <bagasdotme@gmail.com>
To: chenguohua@jari.cn, linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: Clean up errors in sfp.h
Date: Sun, 15 Oct 2023 12:14:02 +0700 [thread overview]
Message-ID: <ZSt1GkmyO_6iit3-@debian.me> (raw)
In-Reply-To: <1a7c167f.942.18b26fb3ec9.Coremail.chenguohua@jari.cn>
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
On Fri, Oct 13, 2023 at 11:01:21AM +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '=' (ctx:VxW)
>
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
> ---
> include/linux/sfp.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/sfp.h b/include/linux/sfp.h
> index 9346cd44814d..725c8381a347 100644
> --- a/include/linux/sfp.h
> +++ b/include/linux/sfp.h
> @@ -289,10 +289,10 @@ enum {
> SFF8024_ENCODING_8B10B = 0x01,
> SFF8024_ENCODING_4B5B = 0x02,
> SFF8024_ENCODING_NRZ = 0x03,
> - SFF8024_ENCODING_8472_MANCHESTER= 0x04,
> + SFF8024_ENCODING_8472_MANCHESTER = 0x04,
> SFF8024_ENCODING_8472_SONET = 0x05,
> SFF8024_ENCODING_8472_64B66B = 0x06,
> - SFF8024_ENCODING_8436_MANCHESTER= 0x06,
> + SFF8024_ENCODING_8436_MANCHESTER = 0x06,
> SFF8024_ENCODING_8436_SONET = 0x04,
> SFF8024_ENCODING_8436_64B66B = 0x05,
> SFF8024_ENCODING_256B257B = 0x07,
> @@ -306,11 +306,11 @@ enum {
> SFF8024_CONNECTOR_MT_RJ = 0x08,
> SFF8024_CONNECTOR_MU = 0x09,
> SFF8024_CONNECTOR_SG = 0x0a,
> - SFF8024_CONNECTOR_OPTICAL_PIGTAIL= 0x0b,
> + SFF8024_CONNECTOR_OPTICAL_PIGTAIL = 0x0b,
> SFF8024_CONNECTOR_MPO_1X12 = 0x0c,
> SFF8024_CONNECTOR_MPO_2X16 = 0x0d,
> SFF8024_CONNECTOR_HSSDC_II = 0x20,
> - SFF8024_CONNECTOR_COPPER_PIGTAIL= 0x21,
> + SFF8024_CONNECTOR_COPPER_PIGTAIL = 0x21,
> SFF8024_CONNECTOR_RJ45 = 0x22,
> SFF8024_CONNECTOR_NOSEPARATE = 0x23,
> SFF8024_CONNECTOR_MXC_2X16 = 0x24,
To be consistent, other enum's indentation should also be aligned to match
the longest ones (MANCHESTER and PIGTAIL).
In netdev, though, checkpatch fixes are not welcome (auto-rejected) as these
make stable backports more convoluted.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-15 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 3:01 [PATCH] net: sfp: Clean up errors in sfp.h chenguohua
2023-10-15 5:14 ` Bagas Sanjaya [this message]
2023-10-15 16:54 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSt1GkmyO_6iit3-@debian.me \
--to=bagasdotme@gmail.com \
--cc=chenguohua@jari.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).