From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 103341A593 for ; Wed, 18 Oct 2023 18:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Dc6sZ40E" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BFB9109; Wed, 18 Oct 2023 11:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=f3MJHUypIUbvYleDUYDG7dFj+nvRTwWrjAosy0aGi4s=; b=Dc6sZ40Emywz0YzszH3PaBlZBi grqQDtPJxA9YZZJg6ZpJkscr0bDkC9pP2+XiS8FE4Fv1tSB6M25b2edSMnm60rE7PiA8eyMN50U+V guTPbveTyn7z008mC+lJVCdOFYnv8eJY8FeuY7UtEL3oQ50pKuuxbDYoNqJzlqdqfDfNyygMvncM3 QJz+ofQBmPRD2IxAtjglQ95JqGuF10VkZvI+oP/pjRIyWlrzYpxkisohVAEmSRDsNKGk26IRBY9w1 u2NcNkvPPUzKXQAQrjsFdaxLTkxflGXlYf2xI4HWJq11/D7BXP17ycAyG1+GSGw8WOCT5G79AneM2 kIezX0Ig==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37734) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qtBjF-0005gt-2K; Wed, 18 Oct 2023 19:57:13 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qtBjF-00081P-EL; Wed, 18 Oct 2023 19:57:13 +0100 Date: Wed, 18 Oct 2023 19:57:13 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Florian Fainelli , Michael Walle , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net] net: mdio-mux: fix C45 access returning -EIO after API change Message-ID: References: <20231017143144.3212657-1-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017143144.3212657-1-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) On Tue, Oct 17, 2023 at 05:31:44PM +0300, Vladimir Oltean wrote: > The mii_bus API conversion to read_c45() and write_c45() did not cover > the mdio-mux driver before read() and write() were made C22-only. > > This broke arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-13bb.dtso. > The -EOPNOTSUPP from mdiobus_c45_read() is transformed by > get_phy_c45_devs_in_pkg() into -EIO, is further propagated to > of_mdiobus_register() and this makes the mdio-mux driver fail to probe > the entire child buses, not just the PHYs that cause access errors. > > Fix the regression by introducing special c45 read and write accessors > to mdio-mux which forward the operation to the parent MDIO bus. > > Fixes: db1a63aed89c ("net: phy: Remove fallback to old C45 method") > Signed-off-by: Vladimir Oltean Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!