From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, johannes.berg@intel.com, mpe@ellerman.id.au,
j@w1.fi
Subject: Re: [PATCH net-next 3/6] net: reduce indentation of __dev_alloc_name()
Date: Fri, 20 Oct 2023 12:26:28 +0200 [thread overview]
Message-ID: <ZTJV1KpirMjxBUBE@nanopsycho> (raw)
In-Reply-To: <20231020011856.3244410-4-kuba@kernel.org>
Fri, Oct 20, 2023 at 03:18:53AM CEST, kuba@kernel.org wrote:
>All callers of __dev_valid_name() go thru dev_prep_valid_name()
>which handles the non-printf case. Focus __dev_alloc_name() on
>the sprintf case, remove the indentation level.
>
>Minor functional change of returning -EINVAL if % is not found,
>which should now never happen.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-10-20 10:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:18 [PATCH net-next 0/6] net: deduplicate netdev name allocation Jakub Kicinski
2023-10-20 1:18 ` [PATCH net-next 1/6] net: don't use input buffer of __dev_alloc_name() as a scratch space Jakub Kicinski
2023-10-20 10:15 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 2/6] net: make dev_alloc_name() call dev_prep_valid_name() Jakub Kicinski
2023-10-20 10:24 ` Jiri Pirko
2023-10-20 19:01 ` Jakub Kicinski
2023-10-21 7:01 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 3/6] net: reduce indentation of __dev_alloc_name() Jakub Kicinski
2023-10-20 10:26 ` Jiri Pirko [this message]
2023-10-20 1:18 ` [PATCH net-next 4/6] net: trust the bitmap in __dev_alloc_name() Jakub Kicinski
2023-10-20 10:38 ` Jiri Pirko
2023-10-20 19:04 ` Jakub Kicinski
2023-10-21 7:00 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 5/6] net: remove dev_valid_name() check from __dev_alloc_name() Jakub Kicinski
2023-10-20 10:39 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 6/6] net: remove else after return in dev_prep_valid_name() Jakub Kicinski
2023-10-20 10:45 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTJV1KpirMjxBUBE@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j@w1.fi \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox