[PATCH net-next 0/2] net: ethernet: renesas: infrastructure preparations for upcoming driver

[PATCH net-next 0/2] net: ethernet: renesas: infrastructure preparations for upcoming driver

[Wolfram Sang]

Before we upstream a new driver, Niklas and I thought that a few
cleanups for Kconfig/Makefile will help readability and maintainability.
Here they are, looking forward to comments.


Wolfram Sang (2):
  net: ethernet: renesas: group entries in Makefile
  net: ethernet: renesas: drop SoC names in Kconfig

 drivers/net/ethernet/renesas/Kconfig  | 9 +--------
 drivers/net/ethernet/renesas/Makefile | 4 +---
 2 files changed, 2 insertions(+), 11 deletions(-)

-- 
2.35.1

[PATCH net-next 1/2] net: ethernet: renesas: group entries in Makefile

[Wolfram Sang]

A new Renesas driver shall be added soon. Prepare the Makefile by
grouping the specific objects to the Kconfig symbol for better
readability. Improve the file description a tad while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/ethernet/renesas/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
index 592005893464..e8fd85b5fe8f 100644
--- a/drivers/net/ethernet/renesas/Makefile
+++ b/drivers/net/ethernet/renesas/Makefile
@@ -1,14 +1,12 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# Makefile for the Renesas device drivers.
+# Makefile for the Renesas network device drivers
 #
 
 obj-$(CONFIG_SH_ETH) += sh_eth.o
 
 ravb-objs := ravb_main.o ravb_ptp.o
-
 obj-$(CONFIG_RAVB) += ravb.o
 
 rswitch_drv-objs := rswitch.o rcar_gen4_ptp.o
-
 obj-$(CONFIG_RENESAS_ETHER_SWITCH) += rswitch_drv.o
-- 
2.35.1

Re: [PATCH net-next 1/2] net: ethernet: renesas: group entries in Makefile

[Sergey Shtylyov]

On 10/22/23 11:53 PM, Wolfram Sang wrote:

> A new Renesas driver shall be added soon. Prepare the Makefile by

   Wow! Another one? :-)

> grouping the specific objects to the Kconfig symbol for better
> readability. Improve the file description a tad while here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

Re: [PATCH net-next 1/2] net: ethernet: renesas: group entries in Makefile

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 45 bytes --]


>    Wow! Another one? :-)

Yes. Hooray ;)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH net-next 2/2] net: ethernet: renesas: drop SoC names in Kconfig

[Wolfram Sang]

Mentioning SoCs in Kconfig descriptions tends to get stale (e.g. RAVB is
missing RZV2M) or imprecise (e.g. SH_ETH is not available on all
R8A779x). Drop them instead of providing vague information. Improve the
file description a tad while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/ethernet/renesas/Kconfig | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig
index 3ceb57408ed0..8ef5b0241e64 100644
--- a/drivers/net/ethernet/renesas/Kconfig
+++ b/drivers/net/ethernet/renesas/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# Renesas device configuration
+# Renesas network device configuration
 #
 
 config NET_VENDOR_RENESAS
@@ -25,9 +25,6 @@ config SH_ETH
 	select PHYLIB
 	help
 	  Renesas SuperH Ethernet device driver.
-	  This driver supporting CPUs are:
-		- SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757,
-		  R8A7740, R8A774x, R8A777x and R8A779x.
 
 config RAVB
 	tristate "Renesas Ethernet AVB support"
@@ -39,8 +36,6 @@ config RAVB
 	select PHYLIB
 	help
 	  Renesas Ethernet AVB device driver.
-	  This driver supports the following SoCs:
-		- R8A779x.
 
 config RENESAS_ETHER_SWITCH
 	tristate "Renesas Ethernet Switch support"
@@ -51,7 +46,5 @@ config RENESAS_ETHER_SWITCH
 	select PHYLINK
 	help
 	  Renesas Ethernet Switch device driver.
-	  This driver supports the following SoCs:
-		- R8A779Fx.
 
 endif # NET_VENDOR_RENESAS
-- 
2.35.1

Re: [PATCH net-next 2/2] net: ethernet: renesas: drop SoC names in Kconfig

[Sergey Shtylyov]

On 10/22/23 11:53 PM, Wolfram Sang wrote:

> Mentioning SoCs in Kconfig descriptions tends to get stale (e.g. RAVB is
> missing RZV2M) or imprecise (e.g. SH_ETH is not available on all
> R8A779x). Drop them instead of providing vague information. Improve the
> file description a tad while here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

Re: [PATCH net-next 2/2] net: ethernet: renesas: drop SoC names in Kconfig

[Paolo Abeni]

On Sun, 2023-10-22 at 22:53 +0200, Wolfram Sang wrote:
> Mentioning SoCs in Kconfig descriptions tends to get stale (e.g. RAVB is
> missing RZV2M) or imprecise (e.g. SH_ETH is not available on all
> R8A779x). Drop them instead of providing vague information. Improve the
> file description a tad while here.

It's not a big deal, but assuming that keeping the SoC list up2date
requires too much effort, I would still keep it, with some additional
wording specifying it's partial and potentially inaccurate.

Such list could be an useful starting point for an integrator looking
for the correct driver for his/her SoC.

Cheers,

Paolo

Re: [PATCH net-next 2/2] net: ethernet: renesas: drop SoC names in Kconfig

[Geert Uytterhoeven]

Hi Paolo,

On Tue, Oct 24, 2023 at 12:54 PM Paolo Abeni <pabeni@redhat.com> wrote:
> On Sun, 2023-10-22 at 22:53 +0200, Wolfram Sang wrote:
> > Mentioning SoCs in Kconfig descriptions tends to get stale (e.g. RAVB is
> > missing RZV2M) or imprecise (e.g. SH_ETH is not available on all
> > R8A779x). Drop them instead of providing vague information. Improve the
> > file description a tad while here.
>
> It's not a big deal, but assuming that keeping the SoC list up2date
> requires too much effort, I would still keep it, with some additional
> wording specifying it's partial and potentially inaccurate.

Apparently it was too much effort...

> Such list could be an useful starting point for an integrator looking
> for the correct driver for his/her SoC.

For modern DT-based systems, it's much easier to look up compatible
values.

See also scripts/dtc/dt_to_config.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH net-next 0/2] net: ethernet: renesas: infrastructure preparations for upcoming driver

[Niklas Söderlund]

Hi Wolfram,

Nice work, for the whole series.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

On 2023-10-22 22:53:14 +0200, Wolfram Sang wrote:
> Before we upstream a new driver, Niklas and I thought that a few
> cleanups for Kconfig/Makefile will help readability and maintainability.
> Here they are, looking forward to comments.
> 
> 
> Wolfram Sang (2):
>   net: ethernet: renesas: group entries in Makefile
>   net: ethernet: renesas: drop SoC names in Kconfig
> 
>  drivers/net/ethernet/renesas/Kconfig  | 9 +--------
>  drivers/net/ethernet/renesas/Makefile | 4 +---
>  2 files changed, 2 insertions(+), 11 deletions(-)
> 
> -- 
> 2.35.1
> 

-- 
Kind Regards,
Niklas Söderlund

Re: [PATCH net-next 0/2] net: ethernet: renesas: infrastructure preparations for upcoming driver

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 22 Oct 2023 22:53:14 +0200 you wrote:
> Before we upstream a new driver, Niklas and I thought that a few
> cleanups for Kconfig/Makefile will help readability and maintainability.
> Here they are, looking forward to comments.
> 
> 
> Wolfram Sang (2):
>   net: ethernet: renesas: group entries in Makefile
>   net: ethernet: renesas: drop SoC names in Kconfig
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: ethernet: renesas: group entries in Makefile
    https://git.kernel.org/netdev/net-next/c/de0ad34b56de
  - [net-next,2/2] net: ethernet: renesas: drop SoC names in Kconfig
    https://git.kernel.org/netdev/net-next/c/2fc75e370e1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html