Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com
Subject: Re: [PATCH net-next] netlink: specs: support conditional operations
Date: Thu, 26 Oct 2023 08:05:06 +0200	[thread overview]
Message-ID: <ZToBkrWEh2Yn/Dqb@nanopsycho> (raw)
In-Reply-To: <20231025162253.133159-1-kuba@kernel.org>

Wed, Oct 25, 2023 at 06:22:53PM CEST, kuba@kernel.org wrote:
>Page pool code is compiled conditionally, but the operations
>are part of the shared netlink family. We can handle this
>by reporting empty list of pools or -EOPNOTSUPP / -ENOSYS
>but the cleanest way seems to be removing the ops completely
>at compilation time. That way user can see that the page
>pool ops are not present using genetlink introspection.
>Same way they'd check if the kernel is "new enough" to
>support the ops.
>
>Extend the specs with the ability to specify the config
>condition under which op (and its policies, etc.) should
>be hidden.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  reply	other threads:[~2023-10-26  6:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 16:22 [PATCH net-next] netlink: specs: support conditional operations Jakub Kicinski
2023-10-26  6:05 ` Jiri Pirko [this message]
2023-10-27  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZToBkrWEh2Yn/Dqb@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox