Re: [PATCH net-next v7 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking

FUJITA Tomonori
2023-10-26T11:54:37Z

On Thu, 26 Oct 2023 13:02:57 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Thu, Oct 26, 2023 at 2:16 AM FUJITA Tomonori
> <fujita.tomonori@gmail.com> wrote:
>>
>> From: Miguel Ojeda <ojeda@kernel.org>
>>
>> This patch makes sure that the C's enum is sync with Rust sides. If
>> the enum is out of sync, compiling fails with an error like the
>> following.
>>
>> Note that this is a temporary solution. It will be replaced with
>> bindgen when it supports generating the enum conversion code.
>
>> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
>
> Please do not modify patches from others without warning that you did
> so. I did not write this commit message nor agreed to this, but it
> looks as if I did. I even explicitly said I would send the patch
> independently.
>
> As I recently told you, if you want to pick it up in your series to
> showcase how it would work, you should have at least kept the WIP, put
> it at the end of the series and added RFC since it is not intended to
> be merged with your other patches.

Sorry, I totally misunderstand your intention. I thought that the PHY
abstractions needs to be merged with your patch together.

I'll drop your patch in the next version and focus on my patches.