Re: [PATCH net] bonding: stop the device in bond_setup_by_slave()

[Hangbin Liu <liuhangbin@gmail.com>]

On Thu, Nov 09, 2023 at 06:01:02PM +0000, Eric Dumazet wrote:
> Commit 9eed321cde22 ("net: lapbether: only support ethernet devices")
> has been able to keep syzbot away from net/lapb, until today.
> 
> In the following splat [1], the issue is that a lapbether device has
> been created on a bonding device without members. Then adding a non
> ARPHRD_ETHER member forced the bonding master to change its type.
> 
> The fix is to make sure we call dev_close() in bond_setup_by_slave()
> so that the potential linked lapbether devices (or any other devices
> having assumptions on the physical device) are removed.
> 
> A similar bug has been addressed in commit 40baec225765
> ("bonding: fix panic on non-ARPHRD_ETHER enslave failure")
> 

Do we need also do this if the bond changed to ether device from other dev
type? e.g.

    if (slave_dev->type != ARPHRD_ETHER)
            bond_setup_by_slave(bond_dev, slave_dev);
    else
            bond_ether_setup(bond_dev);

Thanks
Hangbin