From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E134E2135D; Thu, 2 Nov 2023 19:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="wd8/C0ao" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20CD5136; Thu, 2 Nov 2023 12:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GukiPnfP3Xe/TCueOvIoJT0OZefLfRkX+nqu8Htn41o=; b=wd8/C0aoENJPmgNQ8TeNa+MmYG pSMEdo/P+Z0QSaJHP/bMvwGnGVMqcS+OeNG69bQepqX5ysUypXD7SovHC+GJ00PLmtmZelmOy8nvk ZrRLMS9Z28fHf/QTaSOvJYdLMPCd3HKNqv4eUAQUIlKNjautWB33QlLRWR98IIqUX0hnEPRi7T5q9 XnARcEGsrnG7AFikIYM4Y5CIR/aSgienYfitnY2PEKtu6LduA6Cix18Ne6qNA+8A0Azxiw7VJfZ/F wTk5UuGHldo8zXv5MoY9qnspZYB9g/mvvPxGYezIUdPAZAAdTtrIZkfnL8Vqw1dEVbB5F1xvdQA46 ZtJdbomw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38784) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qydGj-0004u7-19; Thu, 02 Nov 2023 19:22:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qydGY-0007YK-66; Thu, 02 Nov 2023 19:22:06 +0000 Date: Thu, 2 Nov 2023 19:22:06 +0000 From: "Russell King (Oracle)" To: Justin Stitt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com, Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Louis Peens , Shannon Nelson , Brett Creeley , drivers@pensando.io, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Ronak Doshi , VMware PV-Drivers Reviewers , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Hauke Mehrtens , Andrew Lunn , Florian Fainelli , Vladimir Oltean , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Jiawen Wu , Mengyuan Lou , Heiner Kallweit , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Kees Cook , intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com, linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v4 1/3] ethtool: Implement ethtool_puts() Message-ID: References: <20231102-ethtool_puts_impl-v4-0-14e1e9278496@google.com> <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com> Sender: Russell King (Oracle) On Thu, Nov 02, 2023 at 06:55:42PM +0000, Justin Stitt wrote: > +/** > + * ethtool_puts - Write string to ethtool string data > + * @data: Pointer to a pointer to the start of string to update > + * @str: String to write > + * > + * Write string to *data. Update *data to point at start of > + * next string. A minor nit... Sorry to jump in a bit late in this, but... concerning the use of "puts" the userspace stdio version adds a trailing newline. Thus, to avoid any confusion, I think the kerneldoc for this should explicitly state that this does not add a newline. * Write string to *data without a trailing newline. Update *data to * point at the start of the next string. This shouldn't be an issue, but it makes the behaviour of it plainly obvious to the reader. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!