netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <netdev@vger.kernel.org>, David Miller <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Dan Nowlin <dan.nowlin@intel.com>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	Paul Greenwalt <paul.greenwalt@intel.com>,
	Simon Horman <horms@kernel.org>,
	Tony Brelinski <tony.brelinski@intel.com>
Subject: Re: [PATCH net-next 4/6] ice: Add support for E830 DDP package segment
Date: Fri, 3 Nov 2023 14:46:57 +0100	[thread overview]
Message-ID: <ZUT50a94kk2pMGKb@boxer> (raw)
In-Reply-To: <20231025214157.1222758-5-jacob.e.keller@intel.com>

On Wed, Oct 25, 2023 at 02:41:55PM -0700, Jacob Keller wrote:
> From: Dan Nowlin <dan.nowlin@intel.com>
> 
> Add support for E830 DDP package segment. For the E830 package,
> signature buffers will not be included inline in the configuration
> buffers. Instead, the signature buffers will be located in a
> signature segment.

This breaks E810 usage, they go into safe mode. I'll be sending a revert
to this commit or if you have any other idea how to address that I'm all
ears.

> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
> Co-developed-by: Paul Greenwalt <paul.greenwalt@intel.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Tested-by: Tony Brelinski <tony.brelinski@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ddp.c  | 436 ++++++++++++++++++----
>  drivers/net/ethernet/intel/ice/ice_ddp.h  |  27 +-
>  drivers/net/ethernet/intel/ice/ice_type.h |   3 +
>  3 files changed, 387 insertions(+), 79 deletions(-)
> 

  reply	other threads:[~2023-11-03 13:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 21:41 [PATCH net-next 0/6] Intel Wired LAN Driver Updates for 2023-10-25 (ice) Jacob Keller
2023-10-25 21:41 ` [PATCH net-next 1/6] ice: Add E830 device IDs, MAC type and registers Jacob Keller
2023-10-25 21:41 ` [PATCH net-next 2/6] ice: Add 200G speed/phy type use Jacob Keller
2023-10-25 21:41 ` [PATCH net-next 3/6] ice: Add ice_get_link_status_datalen Jacob Keller
2023-10-25 21:41 ` [PATCH net-next 4/6] ice: Add support for E830 DDP package segment Jacob Keller
2023-11-03 13:46   ` Maciej Fijalkowski [this message]
2023-11-03 20:52     ` Jacob Keller
2023-11-04  2:13       ` Nowlin, Dan
2023-10-25 21:41 ` [PATCH net-next 5/6] ice: Remove redundant zeroing of the fields Jacob Keller
2023-10-25 21:41 ` [PATCH net-next 6/6] ice: Hook up 4 E830 devices by adding their IDs Jacob Keller
2023-10-27  5:10 ` [PATCH net-next 0/6] Intel Wired LAN Driver Updates for 2023-10-25 (ice) patchwork-bot+netdevbpf
2023-10-27  5:16   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUT50a94kk2pMGKb@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=dan.nowlin@intel.com \
    --cc=davem@davemloft.net \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.greenwalt@intel.com \
    --cc=tony.brelinski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).