From: Richard Cochran <richardcochran@gmail.com>
To: Edward Adam Davis <eadavis@qq.com>
Cc: davem@davemloft.net, habetsm.xilinx@gmail.com, jeremy@jcline.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
reibax@gmail.com,
syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp_open
Date: Mon, 6 Nov 2023 22:13:27 -0800 [thread overview]
Message-ID: <ZUnVhxktZCpFYwEg@hoboy.vegasvil.org> (raw)
In-Reply-To: <tencent_1372C3B5244E7768777606C0F36563612905@qq.com>
On Mon, Nov 06, 2023 at 10:31:28PM +0800, Edward Adam Davis wrote:
> There is no lock protection when writing ptp->tsevqs in ptp_open() and
> ptp_release(), which can cause data corruption, use spin lock to avoid this
> issue.
>
> Moreover, ptp_release() should not be used to release the queue in ptp_read(),
> and it should be deleted altogether.
>
> Reported-and-tested-by: syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com
> Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers")
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
(This should go to net and not net-next.)
Acked-by: Richard Cochran <richardcochran@gmail.com>
prev parent reply other threads:[~2023-11-07 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231106143127.3936908-3-eadavis@qq.com>
2023-11-06 14:31 ` [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp_open Edward Adam Davis
2023-11-07 6:13 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUnVhxktZCpFYwEg@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=eadavis@qq.com \
--cc=habetsm.xilinx@gmail.com \
--cc=jeremy@jcline.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=reibax@gmail.com \
--cc=syzbot+df3f3ef31f60781fa911@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox