Re: [patch net-next v4 1/7] ip/ipnetns: move internals of get_netnsid_from_name() into namespace.c

[Jiri Pirko <jiri@resnulli.us>]

Mon, Nov 06, 2023 at 06:11:29PM CET, dsahern@gmail.com wrote:
>On 10/27/23 4:13 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>> 
>> In order to be able to reuse get_netnsid_from_name() function outside of
>> ip code, move the internals to lib/namespace.c to a new function called
>> netns_id_from_name().
>> 
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>> ---
>> v3->v4:
>> - removed namespace.h include
>> v2->v3:
>> - s/netns_netnsid_from_name/netns_id_from_name/
>> v1->v2:
>> - new patch
>> ---
>>  include/namespace.h |  2 ++
>>  ip/ipnetns.c        | 45 +----------------------------------------
>>  lib/namespace.c     | 49 +++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 52 insertions(+), 44 deletions(-)
>> 
>
>
>dcb
>    CC       dcb.o
>In file included from dcb.c:11:
>../include/namespace.h:61:31: warning: ‘struct rtnl_handle’ declared
>inside parameter list will not be visible outside of this definition or
>declaration
>   61 | int netns_id_from_name(struct rtnl_handle *rtnl, const char *name);
>      |                               ^~~~~~~~~~~

Ah, I wonder why I didn't hit it. Will fix, thanks!

>
>--
>pw-bot: cr