Re: [PATCH net-next v3] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml

[Jiri Pirko <jiri@resnulli.us>]

Thu, Nov 23, 2023 at 01:29:18PM CET, swarupkotikalapudi@gmail.com wrote:
>On Thu, Nov 23, 2023 at 11:12:15AM +0100, Jiri Pirko wrote:
>> Thu, Nov 23, 2023 at 11:01:19AM CET, swarupkotikalapudi@gmail.com wrote:
>> >Add some missing(not all) attributes in devlink.yaml.
>> >
>> >Re-generate the related devlink-user.[ch] code.
>> >
>> >enum have been given name as devlink_stats(for trap stats)
>> >and devlink_trap_metadata_type(for trap metadata type)
>> >
>> >Test result with trap-get command:
>> >  $ sudo ./tools/net/ynl/cli.py \
>> >   --spec Documentation/netlink/specs/devlink.yaml \
>> >   --do trap-get --json '{"bus-name": "netdevsim", \
>> >                          "dev-name": "netdevsim1", \
>> >   "trap-name": "ttl_value_is_too_small"}' --process-unknown
>> > {'attr-stats': {'rx-bytes': 47918326, 'rx-dropped': 21,
>> >                'rx-packets': 337453},
>> > 'bus-name': 'netdevsim',
>> > 'dev-name': 'netdevsim1',
>> > 'trap-action': 'trap',
>> > 'trap-generic': True,
>> > 'trap-group-name': 'l3_exceptions',
>> > 'trap-metadata': {'metadata-type-in-port': True},
>> > 'trap-name': 'ttl_value_is_too_small',
>> > 'trap-type': 'exception'}
>> 
>> 1. You have to maintain 24 hours between submission of one
>> patch/patchset:
>> https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html
>> 2. You didn't address my comment to last version
>> 
>Hi Jiri,
>
>I have read the above link, but missed the constraint
>of 24 hour gap between patches.
>I will be careful and not send the patch again within 24 hours.
>
>I could not understand your 2nd point.
>Does it mean i should not include
>test result e.g. "Test result with trap-get command: ...."

Does not make sense to me. If you put it like this, it implicates that
the trap attributes are the ones you are introducing in this patch.
However, you introduce much more.


>Or
>If it is something else, please elabroate more, which helps me to address your comment.
>
>I will try to clarify review comment, henceforth before sending new patchset for review.
>
>Thanks,
>Swarup