From: Richard Cochran <richardcochran@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] ptp: annotate data-race around q->head and q->tail
Date: Sat, 11 Nov 2023 16:44:46 -0800 [thread overview]
Message-ID: <ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org> (raw)
In-Reply-To: <20231110115224.3d2f180c@kernel.org>
On Fri, Nov 10, 2023 at 11:52:24AM -0800, Jakub Kicinski wrote:
> Meaning we should revert 8a4f030dbced ("ptp: Fixes a null pointer
> dereference in ptp_ioctl") ?
Yes, I think that would be ideal.
The test itself is harmless, but keeping it will make people think, "oh
this pointer can be invalid."
In fact the core stack ensures that ioctl() can't be invoked after
release(), otherwise Bad Stuff happens.
Thanks,
Richard
next prev parent reply other threads:[~2023-11-12 0:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:48 [PATCH net] ptp: annotate data-race around q->head and q->tail Eric Dumazet
2023-11-10 4:23 ` Richard Cochran
2023-11-10 9:42 ` Eric Dumazet
2023-11-10 17:09 ` Richard Cochran
2023-11-10 19:52 ` Jakub Kicinski
2023-11-12 0:44 ` Richard Cochran [this message]
2023-11-14 4:52 ` Jakub Kicinski
2023-11-14 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).