netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ido Schimmel <idosch@idosch.org>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Roopa Prabhu <roopa@nvidia.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Florian Westphal <fw@strlen.de>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC PATCHv3 net-next 02/10] net: bridge: add document for IFLA_BRPORT enum
Date: Mon, 13 Nov 2023 15:11:57 +0800	[thread overview]
Message-ID: <ZVHMPRBbvfbZGMgJ@Laptop-X1> (raw)
In-Reply-To: <20231111190237.GB705326@kernel.org>

On Sat, Nov 11, 2023 at 07:02:37PM +0000, Simon Horman wrote:
> On Fri, Nov 10, 2023 at 06:15:39PM +0800, Hangbin Liu wrote:
> > Add document for IFLA_BRPORT enum so we can use it in
> > Documentation/networking/bridge.rst.
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> >  include/uapi/linux/if_link.h | 227 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 227 insertions(+)
> > 
> > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> > index 32d6980b78d1..a196a6e4dafb 100644
> > --- a/include/uapi/linux/if_link.h
> > +++ b/include/uapi/linux/if_link.h
> > @@ -792,11 +792,238 @@ struct ifla_bridge_id {
> >  	__u8	addr[6]; /* ETH_ALEN */
> >  };
> >  
> > +/**
> > + * DOC: The bridge mode enum defination
> 
> nit: definition.
> 
> Also in patch 2/10.
> And fields is misspelt in patch 4/10.
> 
> As flagged by checkpatch --codespell

Thanks, I used to use --strict and didn't aware --codespell before.
I will add this parameter in future.

Regards
Hangbin

  parent reply	other threads:[~2023-11-13  7:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10 10:15 [RFC PATCHv3 net-next 00/10] Doc: update bridge doc Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 01/10] net: bridge: add document for IFLA_BR enum Hangbin Liu
2023-11-13  9:14   ` Nikolay Aleksandrov
2023-11-13  9:15   ` Nikolay Aleksandrov
2023-11-10 10:15 ` [RFC PATCHv3 net-next 02/10] net: bridge: add document for IFLA_BRPORT enum Hangbin Liu
2023-11-11 19:02   ` Simon Horman
2023-11-11 19:04     ` Simon Horman
2023-11-13  7:11     ` Hangbin Liu [this message]
2023-11-13  9:44   ` Nikolay Aleksandrov
2023-11-15  8:44     ` Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 03/10] net: bridge: add document for bridge sysfs attribute Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 04/10] docs: bridge: Add kAPI/uAPI fields Hangbin Liu
2023-11-11 19:07   ` Simon Horman
2023-11-13  9:49   ` Nikolay Aleksandrov
2023-11-15  9:13     ` Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 05/10] docs: bridge: add STP doc Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 06/10] docs: bridge: add VLAN doc Hangbin Liu
2023-11-13  9:54   ` Nikolay Aleksandrov
2023-11-15  9:23     ` Hangbin Liu
2023-11-15  9:47       ` Nikolay Aleksandrov
2023-11-15  9:55         ` Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 07/10] docs: bridge: add multicast doc Hangbin Liu
2023-11-13 10:00   ` Nikolay Aleksandrov
2023-11-10 10:15 ` [RFC PATCHv3 net-next 08/10] docs: bridge: add switchdev doc Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 09/10] docs: bridge: add netfilter doc Hangbin Liu
2023-11-10 10:15 ` [RFC PATCHv3 net-next 10/10] docs: bridge: add small features Hangbin Liu
2023-11-13 10:01   ` Nikolay Aleksandrov
2023-11-13  9:43 ` [RFC PATCHv3 net-next 00/10] Doc: update bridge doc Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVHMPRBbvfbZGMgJ@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@idosch.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).