From: Hangbin Liu <liuhangbin@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>, Shuah Khan <shuah@kernel.org>,
David Ahern <dsahern@kernel.org>,
linux-kselftest@vger.kernel.org,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
Guillaume Nault <gnault@redhat.com>
Subject: Re: [Discuss] Seeking advice on net selftests netns naming method
Date: Wed, 15 Nov 2023 15:51:43 +0800 [thread overview]
Message-ID: <ZVR4j+ZYQmb68/V9@Laptop-X1> (raw)
In-Reply-To: <7b2d70645fecf83f30d71c44ae0071da1b3be67c.camel@redhat.com>
On Tue, Nov 14, 2023 at 12:02:00PM +0100, Paolo Abeni wrote:
> I personally would like sort of both :) e.g. lib function(s) to
> automatically create and dispose netns, and retain a script-
> specific/related name prefix.
>
> The library function could optionally set the newly created namespaces
> name in global variables provided by the caller, e.g.:
>
> # create 3 namespaces:
> netns_init 3
>
> # create 3 namespaces and set the global variables:
> # $remote, $local $me
> # to their respective names
> netns_init 3 remote local me
>
> The trick to do such assignment would be using the 'eval' statement,
> something alike
>
> netns_init()
> {
> # create the netns
>
> shift
> while [ -n "$1" ]; do
> eval $1=$NETNS_NAMES[0]
> shift
> done
> }
>
> While at that, it would be useful to package some common helper e.g. to
> wait for a (tcp) listener to be created (available) on a given port.
>
> WDYT?
Thanks, this is a good idea. I reviewed all the test cases and it should works
for most of them. Only the SRv6 tests are a little complex as they use 2 id
number for netns name. e.g. the setup_hs() in
srv6_end_dt46_l3vpn_test.sh. I plan to add the tmp string between the hs/rt and
ids. e.g. hs-xxxxxx-t100-1, rt-xxxxxx-1. I will have a try first.
Cheers
Hangbin
next prev parent reply other threads:[~2023-11-15 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:55 [Discuss] Seeking advice on net selftests netns naming method Hangbin Liu
2023-11-14 11:02 ` Paolo Abeni
2023-11-15 7:51 ` Hangbin Liu [this message]
2023-11-15 9:10 ` Paolo Abeni
2023-11-15 9:35 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVR4j+ZYQmb68/V9@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=po-hsu.lin@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox