From: Jiri Pirko <jiri@resnulli.us>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, edumazet@google.com,
jacob.e.keller@intel.com, jhs@mojatatu.com,
johannes@sipsolutions.net, amritha.nambiar@intel.com,
sdf@google.com
Subject: Re: [patch net-next 8/8] devlink: extend multicast filtering by port index
Date: Thu, 16 Nov 2023 08:10:14 +0100 [thread overview]
Message-ID: <ZVXAVnJQzOKXlUlO@nanopsycho> (raw)
In-Reply-To: <ZVTe_nJ_0N4KnDkd@smile.fi.intel.com>
Wed, Nov 15, 2023 at 04:08:46PM CET, andriy.shevchenko@linux.intel.com wrote:
>On Wed, Nov 15, 2023 at 03:17:24PM +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>>
>> Expose the previously introduced notification multicast messages
>> filtering infrastructure and allow the user to select messages using
>> port index.
>
>...
>
>> struct {
>> __u32 bus_name_len;
>> __u32 dev_name_len;
>> + __u32 port_index:1;
>
>From this context is not clear why others are not bitfields.
Tell it to the generator :)
>
>> } _present;
>>
>> char *bus_name;
>> char *dev_name;
>> + __u32 port_index;
>
>--
>With Best Regards,
>Andy Shevchenko
>
>
next prev parent reply other threads:[~2023-11-16 7:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 14:17 [patch net-next 0/8] devlink: introduce notifications filtering Jiri Pirko
2023-11-15 14:17 ` [patch net-next 1/8] devlink: use devl_is_registered() helper instead xa_get_mark() Jiri Pirko
2023-11-15 20:11 ` Jacob Keller
2023-11-15 14:17 ` [patch net-next 2/8] devlink: introduce __devl_is_registered() helper and use it instead of xa_get_mark() Jiri Pirko
2023-11-15 20:11 ` Jacob Keller
2023-11-15 14:17 ` [patch net-next 3/8] devlink: send notifications only if there are listeners Jiri Pirko
2023-11-15 20:17 ` Jacob Keller
2023-11-16 7:14 ` Jiri Pirko
2023-11-15 14:17 ` [patch net-next 4/8] devlink: introduce a helper for netlink multicast send Jiri Pirko
2023-11-15 20:18 ` Jacob Keller
2023-11-15 14:17 ` [patch net-next 5/8] genetlink: implement release callback and free sk_user_data there Jiri Pirko
2023-11-15 14:17 ` [patch net-next 6/8] genetlink: introduce helpers to do filtered multicast Jiri Pirko
2023-11-15 14:53 ` Andy Shevchenko
2023-11-15 20:20 ` Jacob Keller
2023-11-16 7:15 ` Jiri Pirko
2023-11-15 14:17 ` [patch net-next 7/8] devlink: add a command to set notification filter and use it for multicasts Jiri Pirko
2023-11-15 14:17 ` [patch net-next 8/8] devlink: extend multicast filtering by port index Jiri Pirko
2023-11-15 15:08 ` Andy Shevchenko
2023-11-16 7:10 ` Jiri Pirko [this message]
2023-11-16 9:14 ` [patch net-next 0/8] devlink: introduce notifications filtering Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVXAVnJQzOKXlUlO@nanopsycho \
--to=jiri@resnulli.us \
--cc=amritha.nambiar@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).