Re: [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

Zhang, Xuejun
2023-08-23T21:40:52Z

On 8/22/2023 8:34 AM, Jiri Pirko wrote:
> Tue, Aug 22, 2023 at 05:12:55PM CEST, kuba@kernel.org wrote:
>> On Tue, 22 Aug 2023 08:12:28 +0200 Jiri Pirko wrote:
>>> NACK! Port function is there to configure the VF/SF from the eswitch
>>> side. Yet you use it for the configureation of the actual VF, which is
>>> clear misuse. Please don't
>> Stating where they are supposed to configure the rate would be helpful.
> TC?

Our implementation is an extension to this commit 42c2eb6b1f43 ice:
Implement devlink-rate API).

We are setting the Tx max & share rates of individual queues in a VF
using the devlink rate API.

Here we are using DEVLINK_PORT_FLAVOUR_VIRTUAL as the attribute for the
port to distinguish it from being eswitch.

[resend in plain text only]