From: Wolfram Sang <wsa@kernel.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next 1/5] net: ethernet: renesas: rcar_gen4_ptp: Remove incorrect comment
Date: Fri, 17 Nov 2023 12:49:29 -0500 [thread overview]
Message-ID: <ZVenqeTESTUSOyJq@shikoro> (raw)
In-Reply-To: <20231117164332.354443-2-niklas.soderlund+renesas@ragnatech.se>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Fri, Nov 17, 2023 at 05:43:28PM +0100, Niklas Söderlund wrote:
> The comments intent was to indicates which function uses the enum. While
> upstreaming rcar_gen4_ptp the function was renamed but this comment was
> left with the old function name.
>
> Instead of correcting the comment remove it, it adds little value.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-17 17:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 16:43 [net-next 0/5] net: ethernet: renesas: rcar_gen4_ptp: Add V4H support Niklas Söderlund
2023-11-17 16:43 ` [net-next 1/5] net: ethernet: renesas: rcar_gen4_ptp: Remove incorrect comment Niklas Söderlund
2023-11-17 17:49 ` Wolfram Sang [this message]
2023-11-17 16:43 ` [net-next 2/5] net: ethernet: renesas: rcar_gen4_ptp: Fail on unknown register layout Niklas Söderlund
2023-11-17 17:52 ` Wolfram Sang
2023-11-17 16:43 ` [net-next 3/5] net: ethernet: renesas: rcar_gen4_ptp: Prepare for shared " Niklas Söderlund
2023-11-17 17:56 ` Wolfram Sang
2023-11-17 16:43 ` [net-next 4/5] net: ethernet: renesas: rcar_gen4_ptp: Add V4H clock setting Niklas Söderlund
2023-11-17 18:00 ` Wolfram Sang
2023-11-17 18:51 ` Niklas Söderlund
2023-11-17 21:21 ` Wolfram Sang
2023-11-18 11:16 ` Geert Uytterhoeven
2023-11-18 15:56 ` Niklas Söderlund
2023-11-17 16:43 ` [net-next 5/5] net: ethernet: renesas: rcar_gen4_ptp: Break out to module Niklas Söderlund
2023-11-18 11:20 ` Geert Uytterhoeven
2023-11-18 15:58 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVenqeTESTUSOyJq@shikoro \
--to=wsa@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).