From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: leit@meta.com, Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, donald.hunter@gmail.com,
linux-doc@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: Document each netlink family
Date: Mon, 20 Nov 2023 12:43:11 -0800 [thread overview]
Message-ID: <ZVvE36Sq1LD++Eb9@gmail.com> (raw)
In-Reply-To: <20231120120706.40766380@kernel.org>
On Mon, Nov 20, 2023 at 12:07:06PM -0800, Jakub Kicinski wrote:
> On Mon, 20 Nov 2023 11:55:26 -0800 Breno Leitao wrote:
> > I am not planning to do it, since I would like to trust Make. Let me
> > know if you think this is important and I can do it also.
>
> Makefile is good enough for me.
>
> > +$(YNL_INDEX): $(YNL_RST_FILES)
> > + $(YNL_TOOL) -x # Generate the index
> > +
> > +%.rst: $(YNL_YAMLS_FILES)
> > + $(YNL_TOOL) -i $(patsubst %.rst,%.yaml, $(@F)) # generate individual rst files
>
> IDK what @F means, can the tool take one file at a time and then
> we can make the rule a more usual:
'$(@F)' is the file-within-directory part of the file name of the
target. If the value of ‘$@’ is dir/foo.o then ‘$(@F)’ is foo.o. ‘$(@F)’
is equivalent to ‘$(notdir $@)’.
> %.rst: $(YNL_YAML_DIR)/%.yaml
> $(YNL_TOOL) -i $< -o $@
That is basically what it does now in the current implementation, but,
you don't need to pass the full path and no output file, since it knows
where to get the file and where to save it to.
If you are curious about the current python script, I've pushed it here:
https://github.com/leitao/linux/blob/netdev_discuss/tools/net/ynl/ynl-gen-rst.py
I can easily remove the paths inside the python file and only keep it in
the Makefile, so, we can use -i $< and -o $@.
next prev parent reply other threads:[~2023-11-20 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 20:29 [PATCH v2] Documentation: Document each netlink family Breno Leitao
2023-11-17 22:17 ` Jonathan Corbet
2023-11-18 0:39 ` Jakub Kicinski
2023-11-20 19:55 ` Breno Leitao
2023-11-20 20:07 ` Jakub Kicinski
2023-11-20 20:43 ` Breno Leitao [this message]
2023-11-20 21:14 ` Jakub Kicinski
2023-11-21 11:17 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVvE36Sq1LD++Eb9@gmail.com \
--to=leitao@debian.org \
--cc=corbet@lwn.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).