From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: netlink: link to family documentations from spec info
Date: Tue, 28 Nov 2023 01:39:18 -0800 [thread overview]
Message-ID: <ZWW1Rpwz+Twb1p1L@gmail.com> (raw)
In-Reply-To: <20231127205642.2293153-1-kuba@kernel.org>
On Mon, Nov 27, 2023 at 12:56:42PM -0800, Jakub Kicinski wrote:
> diff --git a/tools/net/ynl/ynl-gen-rst.py b/tools/net/ynl/ynl-gen-rst.py
> index b6292109e236..2c0b80071bcd 100755
> --- a/tools/net/ynl/ynl-gen-rst.py
> +++ b/tools/net/ynl/ynl-gen-rst.py
> @@ -122,6 +122,11 @@ SPACE_PER_LEVEL = 4
> return "\n".join(lines)
>
>
> +def rst_label(title) -> str:
Please add the type hinting to the "title" argument. Something as:
def rst_label(title: str) -> str:
Other than that I am good, and feel free to add:
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2023-11-28 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 20:56 [PATCH net-next] docs: netlink: link to family documentations from spec info Jakub Kicinski
2023-11-28 3:01 ` kernel test robot
2023-11-28 3:06 ` Jakub Kicinski
2023-11-30 8:52 ` Yujie Liu
2023-11-30 15:05 ` Jakub Kicinski
2023-11-28 9:39 ` Breno Leitao [this message]
2023-11-28 10:21 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWW1Rpwz+Twb1p1L@gmail.com \
--to=leitao@debian.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).