Re: [patch net-next v4 5/9] genetlink: introduce per-sock family private pointer storage

Jakub Kicinski
2023-11-27T22:46:27Z

On Thu, 23 Nov 2023 19:15:42 +0100 Jiri Pirko wrote:
> + void __rcu *priv;

How many times did I say "typed struct" in the feedback to the broken
v3 of this series? You complain so much about people not addressing
feedback you've given them, it's really hypocritical.

Put the xarray pointer here directly. Plus a lock to protect the init.

The size of the per-family struct should be in family definition,
allocation should happen on first get automatically. Family definition
should also hold a callback to how the data is going to be freed.
--
pw-bot: cr