From: Daniel Golle <daniel@makrotopia.org>
To: patchwork-bot+netdevbpf@kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
dsahern@gmail.com, dtatulea@nvidia.com, willemb@google.com,
almasrymina@google.com, shakeelb@google.com
Subject: Re: [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection
Date: Wed, 29 Nov 2023 20:10:01 +0000 [thread overview]
Message-ID: <ZWeamcTq9kv0oGd4@makrotopia.org> (raw)
In-Reply-To: <170118422773.21698.10391322196700008288.git-patchwork-notify@kernel.org>
Hi Paolo,
after the merge of this series to linux-next I'm seeing a new crash
during boot.
It can absolutely be that this is a bug in the Ethernet driver I'm
working on though which only got exposed now. While I'm figuring it
out I thought it'd still be good to let you know.
[ 15.626854] Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000
[ 15.637571] Mem abort info:
[ 15.640361] ESR = 0x0000000096000045
[ 15.644115] EC = 0x25: DABT (current EL), IL = 32 bits
[ 15.649431] SET = 0, FnV = 0
[ 15.652485] EA = 0, S1PTW = 0
[ 15.655622] FSC = 0x05: level 1 translation fault
[ 15.660494] Data abort info:
[ 15.663374] ISV = 0, ISS = 0x00000045, ISS2 = 0x00000000
[ 15.668855] CM = 0, WnR = 1, TnD = 0, TagAccess = 0
[ 15.673904] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 15.679210] user pgtable: 4k pages, 39-bit VAs, pgdp=00000001055e6000
[ 15.685647] [0000000000000000] pgd=0800000105680003, p4d=0800000105680003, pud=0800000105680003, pmd=0000000000000000
[ 15.696265] Internal error: Oops: 0000000096000045 [#1] SMP
[ 15.701826] Modules linked in: option nft_fib_inet nf_flow_table_inet cdc_mbim wireguard usb_wwan qmi_wwan nft_reject_ipv6 nft_reject_ipv4 nft_reject_inet nft_reject nft_redir nft_quota nft_numgen nft_nat nft_masq nft_log nft_limit nfs
[ 15.702009] uas usb_storage leds_gpio xhci_plat_hcd xhci_pci xhci_mtk_hcd xhci_hcd usbcore usb_common mii
[ 15.801633] CPU: 0 PID: 3294 Comm: netifd Tainted: G O 6.7.0-rc3-next-20231129+ #0
[ 15.810579] Hardware name: Bananapi BPI-R4 (DT)
[ 15.815097] pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 15.822047] pc : page_pool_unlist+0x40/0x74
[ 15.826227] lr : page_pool_unlist+0x38/0x74
[ 15.830400] sp : ffffffc0868639d0
[ 15.833703] x29: ffffffc0868639d0 x28: ffffff80c5e5c800 x27: 0000000000000000
[ 15.840829] x26: 0000000000000001 x25: ffffffc080bab958 x24: ffffffc080a28f68
[ 15.847954] x23: ffffffc08071e61c x22: 0000000000000000 x21: 0000000000000000
[ 15.855078] x20: ffffffc080d48740 x19: ffffff80c199a800 x18: 0000000000000000
[ 15.862203] x17: ffffffc07eafc000 x16: ffffffc080000000 x15: 0000007fd42c1f68
[ 15.869328] x14: ffffff80c011c8c0 x13: 0123837901209924 x12: ffffff80c32e2cc0
[ 15.876453] x11: ffffff80c199d000 x10: 0000000000000002 x9 : 0000000000000001
[ 15.883577] x8 : 0000000000000238 x7 : 0000000000000000 x6 : 0000000000000000
[ 15.890702] x5 : 0000000000000000 x4 : ffffff80c06b86c8 x3 : 0000000000000000
[ 15.897826] x2 : 0000000000000000 x1 : ffffff80c199ae00 x0 : 0000000000000000
[ 15.904951] Call trace:
[ 15.907386] page_pool_unlist+0x40/0x74
[ 15.911211] page_pool_release+0x1f8/0x270
[ 15.915300] page_pool_destroy+0xa4/0x160
[ 15.919300] mtk_rx_clean+0x1a4/0x200
[ 15.922955] mtk_dma_free+0x150/0x234
[ 15.926607] mtk_stop+0x320/0x3b0
[ 15.929913] __dev_close_many+0xb4/0x114
[ 15.933826] __dev_change_flags+0x11c/0x18c
[ 15.938000] dev_change_flags+0x20/0x64
[ 15.941827] dev_ifsioc+0x204/0x4b8
[ 15.945307] dev_ioctl+0x144/0x4b4
[ 15.948700] sock_ioctl+0x1c8/0x44c
[ 15.952180] __arm64_sys_ioctl+0x520/0xf78
[ 15.956268] invoke_syscall.constprop.0+0x4c/0xdc
[ 15.960964] do_el0_svc+0x3c/0xb8
[ 15.964269] el0_svc+0x18/0x4c
[ 15.967315] el0t_64_sync_handler+0xf8/0x124
[ 15.971575] el0t_64_sync+0x150/0x154
[ 15.975229] Code: 9100e280 9409349f 91180261 a9430820 (f9000040)
[ 15.981310] ---[ end trace 0000000000000000 ]---
[ 15.987456] pstore: backend (ramoops) writing error (-28)
[ 15.992843] Kernel panic - not syncing: Oops: Fatal exception
[ 15.998576] SMP: stopping secondary CPUs
[ 16.002489] Kernel Offset: disabled
[ 16.005965] CPU features: 0x0,00000000,40000000,2100400b
[ 16.011264] Memory Limit: none
[ 16.015862] Rebooting in 3 seconds..
PANIC at PC : 0x000000004300490c
Cheers
Daniel
On Tue, Nov 28, 2023 at 03:10:27PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This series was applied to netdev/net-next.git (main)
> by Paolo Abeni <pabeni@redhat.com>:
>
> On Sun, 26 Nov 2023 15:07:27 -0800 you wrote:
> > We recently started to deploy newer kernels / drivers at Meta,
> > making significant use of page pools for the first time.
> > We immediately run into page pool leaks both real and false positive
> > warnings. As Eric pointed out/predicted there's no guarantee that
> > applications will read / close their sockets so a page pool page
> > may be stuck in a socket (but not leaked) forever. This happens
> > a lot in our fleet. Most of these are obviously due to application
> > bugs but we should not be printing kernel warnings due to minor
> > application resource leaks.
> >
> > [...]
>
> Here is the summary with links:
> - [net-next,v4,01/13] net: page_pool: factor out uninit
> https://git.kernel.org/netdev/net-next/c/23cfaf67ba5d
> - [net-next,v4,02/13] net: page_pool: id the page pools
> https://git.kernel.org/netdev/net-next/c/f17c69649c69
> - [net-next,v4,03/13] net: page_pool: record pools per netdev
> https://git.kernel.org/netdev/net-next/c/083772c9f972
> - [net-next,v4,04/13] net: page_pool: stash the NAPI ID for easier access
> https://git.kernel.org/netdev/net-next/c/02b3de80c5f8
> - [net-next,v4,05/13] eth: link netdev to page_pools in drivers
> https://git.kernel.org/netdev/net-next/c/7cc9e6d77f85
> - [net-next,v4,06/13] net: page_pool: add nlspec for basic access to page pools
> https://git.kernel.org/netdev/net-next/c/839ff60df3ab
> - [net-next,v4,07/13] net: page_pool: implement GET in the netlink API
> https://git.kernel.org/netdev/net-next/c/950ab53b77ab
> - [net-next,v4,08/13] net: page_pool: add netlink notifications for state changes
> https://git.kernel.org/netdev/net-next/c/d2ef6aa077bd
> - [net-next,v4,09/13] net: page_pool: report amount of memory held by page pools
> https://git.kernel.org/netdev/net-next/c/7aee8429eedd
> - [net-next,v4,10/13] net: page_pool: report when page pool was destroyed
> https://git.kernel.org/netdev/net-next/c/69cb4952b6f6
> - [net-next,v4,11/13] net: page_pool: expose page pool stats via netlink
> https://git.kernel.org/netdev/net-next/c/d49010adae73
> - [net-next,v4,12/13] net: page_pool: mute the periodic warning for visible page pools
> https://git.kernel.org/netdev/net-next/c/be0096676e23
> - [net-next,v4,13/13] tools: ynl: add sample for getting page-pool information
> https://git.kernel.org/netdev/net-next/c/637567e4a3ef
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>
>
next prev parent reply other threads:[~2023-11-29 20:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 23:07 [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 01/13] net: page_pool: factor out uninit Jakub Kicinski
2023-11-27 6:56 ` Shakeel Butt
2023-11-26 23:07 ` [PATCH net-next v4 02/13] net: page_pool: id the page pools Jakub Kicinski
2023-11-27 7:07 ` Shakeel Butt
2023-11-28 14:47 ` Paolo Abeni
2023-11-26 23:07 ` [PATCH net-next v4 03/13] net: page_pool: record pools per netdev Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 04/13] net: page_pool: stash the NAPI ID for easier access Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 05/13] eth: link netdev to page_pools in drivers Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 06/13] net: page_pool: add nlspec for basic access to page pools Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 07/13] net: page_pool: implement GET in the netlink API Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 08/13] net: page_pool: add netlink notifications for state changes Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 09/13] net: page_pool: report amount of memory held by page pools Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 10/13] net: page_pool: report when page pool was destroyed Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 11/13] net: page_pool: expose page pool stats via netlink Jakub Kicinski
2023-11-28 15:01 ` Ilias Apalodimas
2023-11-26 23:07 ` [PATCH net-next v4 12/13] net: page_pool: mute the periodic warning for visible page pools Jakub Kicinski
2023-11-28 15:00 ` Ilias Apalodimas
2023-11-26 23:07 ` [PATCH net-next v4 13/13] tools: ynl: add sample for getting page-pool information Jakub Kicinski
2023-11-28 15:10 ` [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection patchwork-bot+netdevbpf
2023-11-29 20:10 ` Daniel Golle [this message]
2023-11-29 21:12 ` Eric Dumazet
2023-11-30 0:03 ` Jakub Kicinski
2023-11-30 2:09 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWeamcTq9kv0oGd4@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=shakeelb@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).