Re: [PATCH v5 3/3] NFSD: convert write_ports to netlink command

Jeff Layton
2023-11-30T16:22:49Z

On Thu, 2023-11-30 at 10:57 +0100, Lorenzo Bianconi wrote:
> > >
> > > +/* ============== NFSD_CMD_LISTENER_START ============== */
> > > +/* NFSD_CMD_LISTENER_START - do */
> > > +struct nfsd_listener_start_req {
> > > + struct {
> > > + __u32 transport_name_len;
> > > + __u32 port:1;
> > > + } _present;
> > > +
> > > + char *transport_name;
> > > + __u32 port;
> > > +};
> >
> > How do you deconfigure a listener with this interface? i.e. suppose I
> > want to stop nfsd from listening on a particular port? I think this too
> > is a place where a declarative interface would be better:
>
> Is it possible with current APIs? as for 2/3 so far I have just added netlink
> counter for current implementation but I am fine to change the logic here to
> better APIs.
>
> >

No, I don't think you can do this with the current API at all. I
consider it a major deficiency. I don't think we want to repeat that
mistake in the new interface.

> > Have userland send down a list of the ports that we should currently be
> > listening on, and let the kernel do the work to match the request. Again
> > too, an empty list could mean "close everything".
> >
> >

--
Jeff Layton <jlayton@kernel.org>