From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew@lunn.ch, netdev@vger.kernel.org,
mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v3 2/7] net: wangxun: unified phylink implementation in libwx
Date: Wed, 6 Dec 2023 12:15:45 +0000 [thread overview]
Message-ID: <ZXBl8VCncGJSpkad@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231206095355.1220086-3-jiawenwu@trustnetic.com>
On Wed, Dec 06, 2023 at 05:53:50PM +0800, Jiawen Wu wrote:
> Use wx->phylink instead of txgbe->phylink, and move the same ethtool
> functions to libwx because them can be implemented with phylink in
> ngbe driver.
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
I would probably do the first two patches of your series differently:
Patch 1: add struct phylink + phylink_config to the wx structure, and
add the helper functions for ksettings and nway reset.
Patch 2: convert txgbe to use the bits added in patch 1.
Patch 3: convert ngbe to phylink using the wx bits added in the first
patch as a pure phylink conversion.
Patch 4: change how the PHY is attached/detached (as mentioned in the
review of your existing first patch.)
which probably would have been easier to review.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-12-06 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 9:53 [PATCH net-next v3 0/7] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 1/7] net: ngbe: implement phylink to handle PHY device Jiawen Wu
2023-12-06 12:06 ` Russell King (Oracle)
2023-12-08 7:12 ` Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 2/7] net: wangxun: unified phylink implementation in libwx Jiawen Wu
2023-12-06 12:15 ` Russell King (Oracle) [this message]
2023-12-06 9:53 ` [PATCH net-next v3 3/7] net: wangxun: add flow control support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 4/7] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-12-06 17:37 ` Jakub Kicinski
2023-12-06 9:53 ` [PATCH net-next v3 5/7] net: wangxun: add coalesce options support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 6/7] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-12-06 17:35 ` Jakub Kicinski
2023-12-06 9:53 ` [PATCH net-next v3 7/7] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXBl8VCncGJSpkad@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).