Re: [PATCH net-next v5] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml

Jiri Pirko
2023-12-10T11:47:29Z

Fri, Dec 08, 2023 at 07:30:05PM CET, swarupkotikalapudi@gmail.com wrote:
>On Wed, Dec 06, 2023 at 08:06:11AM -0800, Jakub Kicinski wrote:
>> On Wed, 6 Dec 2023 08:51:54 +0100 Jiri Pirko wrote:
>> > My "suggested-by" is probably fine as I suggested Swarup to make the patch :)
>>
>> Ah, I didn't realize, sorry :) Just mine needs to go then.
>
>Hi Jiri,
>
>Please find answer for some quesion from you.
>
>1. I removed the Fixes tag.
>
>2. I removed Jakub's name from Suggested-by tag.
>
>3. I added new line as suggested.
>
> value: ## or number, is used only if there is a gap or
> missing attribute just above of any attribute which is not yet filled.
>
>4. dl-attr-stats has a value 0 as shown below for this reason:
> name: dl-attr-stats
> name-prefix: devlink-attr-
> attributes:
> - name: stats-rx-packets
> type: u64
> value: 0 <-- 0 is added here due to below mentioned reason
> but mainly to match order of stats unnamed enum declared in include/uapi/linux/devlink.h

So, by default, it starts with 1?

> -
> name: stats-rx-bytes
> type: u64
> -
> name: stats-rx-dropped
> type: u64