Re: [PATCH net v3 2/2] selftests: add vlan hw filter tests

[Hangbin Liu <liuhangbin@gmail.com>]

On Sat, Dec 16, 2023 at 03:52:19PM +0800, Liu Jian wrote:
> Add one basic vlan hw filter test.
> 
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> ---
>  tools/testing/selftests/net/Makefile          |  1 +
>  tools/testing/selftests/net/vlan_hw_filter.sh | 29 +++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100755 tools/testing/selftests/net/vlan_hw_filter.sh
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 5b2aca4c5f10..9e5bf59a20bf 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -91,6 +91,7 @@ TEST_PROGS += test_bridge_neigh_suppress.sh
>  TEST_PROGS += test_vxlan_nolocalbypass.sh
>  TEST_PROGS += test_bridge_backup_port.sh
>  TEST_PROGS += fdb_flush.sh
> +TEST_PROGS += vlan_hw_filter.sh
>  
>  TEST_FILES := settings
>  
> diff --git a/tools/testing/selftests/net/vlan_hw_filter.sh b/tools/testing/selftests/net/vlan_hw_filter.sh
> new file mode 100755
> index 000000000000..7bc804ffaf7c
> --- /dev/null
> +++ b/tools/testing/selftests/net/vlan_hw_filter.sh
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +readonly NETNS="ns-$(mktemp -u XXXXXX)"
> +
> +ret=0
> +
> +cleanup() {
> +	ip netns del $NETNS
> +}
> +
> +trap cleanup EXIT
> +
> +fail() {
> +    echo "ERROR: ${1:-unexpected return code} (ret: $_)" >&2
> +    ret=1
> +}
> +
> +ip netns add ${NETNS}
> +ip netns exec ${NETNS} ip link add bond0 type bond mode 0
> +ip netns exec ${NETNS} ip link add bond_slave_1 type veth peer veth2
> +ip netns exec ${NETNS} ip link set bond_slave_1 master bond0
> +ip netns exec ${NETNS} ethtool -K bond0 rx-vlan-filter off
> +ip netns exec ${NETNS} ip link add link bond_slave_1 name bond_slave_1.0 type vlan id 0
> +ip netns exec ${NETNS} ip link add link bond0 name bond0.0 type vlan id 0
> +ip netns exec ${NETNS} ip link set bond_slave_1 nomaster
> +ip netns exec ${NETNS} ip link del veth2 || fail "Please check vlan HW filter function"
> +
> +exit $ret
> -- 
> 2.34.1
> 

Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

Thanks
Hangbin