public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: selftest fib_nexthop_multiprefix failed due to route mismatch
Date: Mon, 11 Dec 2023 17:22:22 +0800	[thread overview]
Message-ID: <ZXbUzpDGErm-JXSC@Laptop-X1> (raw)
In-Reply-To: <02ef5de4-d57f-4037-8968-d9bf791bd903@kernel.org>

On Fri, Dec 08, 2023 at 12:21:55PM -0700, David Ahern wrote:
> > Hi David,
> > 
> > I re-test this on 6.4.0 and it also failed. So this looks like an env issue
> > on your side?
> > 
> > # uname -r
> > 6.4.0
> > # ./fib_nexthop_multiprefix.sh
> > TEST: IPv4: host 0 to host 1, mtu 1300                              [ OK ]
> > TEST: IPv6: host 0 to host 1, mtu 1300                              [FAIL]
> > 
> > And from the test result, it looks we should receive the Packet too big message
> > from r1. So look the current checking is incorrect and the "from ::" checking
> > should be removed.
> > 
> > Please fix me if I missed anything?
> > 
> 
> I ran it in a ubuntu 20.04 VM. Do not recall any specific sysctl
> settings to the VM, but maybe something is different between U20.04 and
> your OS

OK, I got the reason. The "from ::1" is put in rt6_fill_node()
when CONFIG_IPV6_SUBTREES is enabled. I will fix this grep issue
in my next selftests namespace conversion patch set.

Thanks
Hangbin

  reply	other threads:[~2023-12-11  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  6:40 selftest fib_nexthop_multiprefix failed due to route mismatch Hangbin Liu
2023-11-21 17:40 ` David Ahern
2023-12-06  3:47   ` Hangbin Liu
2023-12-08 19:21     ` David Ahern
2023-12-11  9:22       ` Hangbin Liu [this message]
2023-12-11 13:45         ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXbUzpDGErm-JXSC@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox