From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="BT6S/XMZ" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3E16CE; Tue, 12 Dec 2023 11:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IjbNLBnXJMkEPuo14QetPgRXWjPIn+/9Sx2GduCHfXA=; b=BT6S/XMZL/rzU9HjAnFEu7NGGR upEveRnxQ+NPn39oOLaeAuRuDC03OcuH9sGUuCIInrTiiMfZyptebSEHaOlCb+d3e1ltrga1Uu7fn vpZYcKUgJHlIuJFptgzg+Iwm51DET8VPWvjf+mk9KfOtqLZoAvTOYinmyXYnIWx+lfQheXc9lYM2i fx5tD2aAZ9C5C459TvYc5CYrrASTXZeTN7uJ7aKSCUeWKwMSn4IjEVoT/oxIN8RPqoZs+sXVTUaEg rJCkeJ1P/Yf0aj18LnYqWK5teotB7rfvz/8Yq5deB1+erDYaendz6E2Y4S/ltezUTgJcwj2wRVHFS Yj1wiGvw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49216) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rD8HV-0007JO-2r; Tue, 12 Dec 2023 19:19:01 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rD8HX-0000hW-T4; Tue, 12 Dec 2023 19:19:03 +0000 Date: Tue, 12 Dec 2023 19:19:03 +0000 From: "Russell King (Oracle)" To: Stefan Eichenberger Cc: maxime.chevallier@bootlin.com, mw@semihalf.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: mvpp2: add support for mii Message-ID: References: <20231212141200.62579-1-eichest@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212141200.62579-1-eichest@gmail.com> Sender: Russell King (Oracle) On Tue, Dec 12, 2023 at 03:12:00PM +0100, Stefan Eichenberger wrote: > Currently, mvpp2 only supports RGMII. This commit adds support for MII. > The description in Marvell's functional specification seems to be wrong. > To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMII > we need to clear it. This is also how U-Boot handles it. > > Signed-off-by: Stefan Eichenberger LGTM. Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!