From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="UKn9eDat" Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092EC1FE1 for ; Wed, 13 Dec 2023 07:44:36 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c9f8faf57bso90805881fa.3 for ; Wed, 13 Dec 2023 07:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1702482274; x=1703087074; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5Yloh5WLaUgQc2tYcTCRv7Yyx/Oia7K8qQ5mNJQ1J/4=; b=UKn9eDatG22DZvdgGR1qD0lMKea2QvcUxOy6YDeq8wwYKNgQ2c1UmaRPCpxDQQTRbQ ixzvY8TG66VmDXh4E+oZ9inZWnSzzsg+5tVXz5rIbtRNg3ZrqYoZ/Rx+8UU299YksZr9 ai9EKfkbkt9v6Y1FGZEmac2PxVAWXnYZbIpAgGA5HJ1Oh9zCiun1fjiRoKnZHMlwDc8+ aHPTIzHzSYrZiOeMY9+YqVEivVTrKQ+fn30uL/uyxml4B4h2YoBIv9k7/hBttL23bw+T TnpUl0HFVNvRxvpOU/YfAiO0tp6DTgQeffNgZZ9zA9MdVf0xVhi8Oxf3SP56iUmibE6+ 3jtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702482274; x=1703087074; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Yloh5WLaUgQc2tYcTCRv7Yyx/Oia7K8qQ5mNJQ1J/4=; b=pgvYmQCf2JWNCB09hedGtlFX5H8s86XkA6qzg1IHOMpXXIQ79V7FHRuPV9jqYIer7T +4CrkGOwZvLcwwRehZFlzq+VG8NIkIr/OB77JS3SzwUJ9M8a8l20iix2Yn/RJS6f3wuO l8I9EElH3tajYBUmiSSg0CaNxuB800qmQ7IA6GWL7iTp+k3Fl+5URTBxa9gKcskC+ywz f7w2XMpeLNNy7B0WIpk5rgV7utZmshlFCs1kmzHv0RiFAwWhuwQrrEQZSl9HvaGb5R4h qEmd9qvSgEIHpzwxmaipGvYOk6zrIHE1hpLx3QS7JGAE9/GzPU8aGzpwXQGy+1PHzqvF W25w== X-Gm-Message-State: AOJu0YzX9nNqRtFZM07qWka8jcfCcAYY5uFqa6fH6HFL+IeK13cfS7Es q0mqOQ/8iOmlANTVJBOBdK2ZzQ== X-Google-Smtp-Source: AGHT+IFr7Oqvx4CK1tZt/dRJIgK0/zYJ4CyNAruBeSg6T6baM9XWOvzPiWiKTAgW2oK6YHTWHiqPag== X-Received: by 2002:a2e:9802:0:b0:2ca:688:8408 with SMTP id a2-20020a2e9802000000b002ca06888408mr3411506ljj.75.1702482274167; Wed, 13 Dec 2023 07:44:34 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id n8-20020a50cc48000000b0054c9df4317dsm5797809edi.7.2023.12.13.07.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 07:44:33 -0800 (PST) Date: Wed, 13 Dec 2023 16:44:32 +0100 From: Jiri Pirko To: Hangbin Liu Cc: netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni Subject: Re: [Draft PATCH net-next 2/3] net: team: use policy generated by YAML spec Message-ID: References: <20231213084502.4042718-1-liuhangbin@gmail.com> <20231213084502.4042718-3-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213084502.4042718-3-liuhangbin@gmail.com> Wed, Dec 13, 2023 at 09:45:01AM CET, liuhangbin@gmail.com wrote: >generated with: > > $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \ > > --spec Documentation/netlink/specs/team.yaml --source \ > > -o drivers/net/team/team_nl.c > $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \ > > --spec Documentation/netlink/specs/team.yaml --header \ > > -o drivers/net/team/team_nl.h > >The TEAM_ATTR_LIST_PORT in team_nl_policy is removed as it only in the "only is in the" ? Looks like you are missing verb somewhere anyway. Overall looks fine. >port list reply attributes. >